Fix for GetService() implementation of FuncDependencyResolver #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion of a service 2) Actually this is consistent with the way ModernDependencyResolver works (https://github.com/reactiveui/ReactiveUI/blob/42e580f9d10db4e32c827273e57d0ac997421d86/ReactiveUI/ModernDependencyResolver.cs#L49)
|
I'm in general +1 on this, although it would be a breaking change, so we should be careful. The interface contract currently does not specify which object is returned if multiple are registered, but we could make that explicit with this PR. |
|
True, it'd be a breaking change. Or we can provide an optional third parameter in FuncDependencyResolver's ctor for getService func. Sounds much better than a breaking change. Any more ideas? |
|
This is the way it should've been from day one, forgot to fix this up. Thanks @journeyman! I don't think it will break anybody, since the previous behavior was kind of useless |
anaisbetts
pushed a commit
that referenced
this pull request
Oct 28, 2013
Fix for GetService() implementation of FuncDependencyResolver
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use FuncDependencyResolver with my 3rd party IoC and I'm unable to overwrite default registration of DebugLogger with my ILogger implementation, this PR fixes it