Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Use GitHub Actions #258

Merged
merged 10 commits into from Oct 26, 2020
Merged

housekeeping: Use GitHub Actions #258

merged 10 commits into from Oct 26, 2020

Conversation

RLittlesII
Copy link
Member

What kind of change does this PR introduce?

Migrates away from Azure Devops to GitHub Actions

What is the current behavior?

Building on Azure Pipelines

What is the new behavior?

building on GitHub Actions

What might this PR break?

The build

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@codecov
Copy link

codecov bot commented Oct 24, 2020

Codecov Report

Merging #258 into main will increase coverage by 0.48%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
+ Coverage   53.38%   53.87%   +0.48%     
==========================================
  Files          17       23       +6     
  Lines         487      542      +55     
  Branches       80       83       +3     
==========================================
+ Hits          260      292      +32     
- Misses        203      225      +22     
- Partials       24       25       +1     
Impacted Files Coverage Δ
src/Sextant/Sextant.cs
.../Sextant/System/Reactive/Linq/ToSignalExtension.cs
src/Sextant/Navigation/ViewStackService.cs
src/Sextant/DefaultViewModelFactory.cs
...rc/Sextant/Navigation/ViewModelActionExtensions.cs
src/Sextant.XamForms/SextantHelper.cs
...extant.XamForms/Mixins/DependencyResolverMixins.cs
src/Sextant/ViewModelFactoryNotFoundException.cs
src/Sextant/DependencyResolverMixins.cs
src/Sextant/Navigation/ViewStackServiceBase.cs
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97af0c0...32f4ba6. Read the comment docs.

@glennawatson
Copy link
Contributor

Update to your test to be against .net core 3.1 and it should fix one of your build issues.

@glennawatson
Copy link
Contributor

glennawatson commented Oct 24, 2020

  • You'll need to add coverlet msbuild
  • Delete cake files
  • Delete azure pipelines file
  • Remove shouldly
  • Update stylecop analyser
  • Use DiffEngine API approval from fusillade

@glennawatson
Copy link
Contributor

glennawatson commented Oct 24, 2020

In a separate pr

  • Change GitHub actions badge to readme
  • remove azure DevOps from branch pr required actions for approval.
  • Add GitHub action build to the branch pr requirements

@RLittlesII RLittlesII merged commit 3fd846c into main Oct 26, 2020
@RLittlesII RLittlesII deleted the feature/actions branch October 26, 2020 16:47
@reactiveui reactiveui locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants