feature: add GetValue methods to INavigationParameter #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added tests added test fixed comments fixed error fixing approval tests
Codecov Report
@@ Coverage Diff @@
## main #308 +/- ##
==========================================
- Coverage 66.45% 66.41% -0.04%
==========================================
Files 30 31 +1
Lines 799 807 +8
==========================================
+ Hits 531 536 +5
- Misses 268 271 +3
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds genetic value methods for getting parameters.
What is the current behavior?
You have to cast them yourself.
What is the new behavior?
use a generic
GetorTryGetWhat might this PR break?
navigation parameters
Please check if the PR fulfills these requirements
Other information: