fix: PopToRoot doesn't clear PageStack #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed PopToRoot not notifying and clearing stack - fixed properties returning subjects - migrated to await syntax in tests - Added PopToRoot to Sample
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
=========================================
+ Coverage 30.41% 36.4% +5.99%
=========================================
Files 6 6
Lines 194 206 +12
Branches 26 28 +2
=========================================
+ Hits 59 75 +16
+ Misses 133 129 -4
Partials 2 2
Continue to review full report at Codecov.
|
glennawatson
approved these changes
May 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Added some test coverage and fixed a few issues
What is the current behavior?
Resolves: #57
What is the new behavior?
PopToRootclears theViewStackService.PageStackWhat might this PR break?
Nothing
Please check if the PR fulfills these requirements