Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#781 optimize dependencies #784

Conversation

thompson-tomo
Copy link

What kind of change does this PR introduce?
update

What is the current behavior?
Packages are the same for all TFM's

What is the new behavior?
Less dependencies are included for net 6+ due to them being available as part of the framework

What might this PR break?
n/a

Other information:
closes #781

@thompson-tomo thompson-tomo force-pushed the chore/#781_optimiseDependencies branch from 18bc476 to de76747 Compare July 18, 2024 22:31
@ChrisPulman
Copy link
Member

Your description of the PR seems different from the actual changes, you are adding dependencies rather than removing as stated.
If there is a logical reason for the additional packages please make it clear, thank you.

@thompson-tomo thompson-tomo force-pushed the chore/#781_optimiseDependencies branch from de76747 to 0d7707d Compare July 22, 2024 08:20
@thompson-tomo
Copy link
Author

Given the age of this PR, my first guess is that the changes I am wanting were done as a part of another PR. Hence why the diff is so small after the rebase. I will check this and close if so.

@thompson-tomo
Copy link
Author

close as done via different PR.

@thompson-tomo thompson-tomo deleted the chore/#781_optimiseDependencies branch July 22, 2024 09:52
Copy link

github-actions bot commented Aug 6, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use framework dependency rather than explicit
2 participants