Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Fix nullability, use newest System.Reactive #125

Merged
merged 3 commits into from Jan 4, 2021

Conversation

worldbeater
Copy link
Contributor

What kind of change does this PR introduce?

This fixes nullability errors that arise after System.Reactive upgrade in #113

@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #125 (d5172d8) into main (3d1e462) will increase coverage by 0.43%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   67.22%   67.65%   +0.43%     
==========================================
  Files           6        6              
  Lines         299      303       +4     
==========================================
+ Hits          201      205       +4     
  Misses         98       98              
Impacted Files Coverage Δ
src/Punchclock/KeyedOperation.cs 84.21% <100.00%> (+0.87%) ⬆️
src/Punchclock/OperationQueue.cs 86.95% <100.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d1e462...d5172d8. Read the comment docs.

@worldbeater worldbeater marked this pull request as ready for review January 4, 2021 11:49
@glennawatson glennawatson merged commit 81f77be into main Jan 4, 2021
@glennawatson glennawatson deleted the fix-nullability branch January 4, 2021 12:14
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants