Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enchance SystemTextJsonContentSerializer default options #1235

Merged
merged 2 commits into from
Sep 4, 2021

Conversation

DsAekb
Copy link
Contributor

@DsAekb DsAekb commented Sep 4, 2021

What kind of change does this PR introduce?
This is a new feature that extends/enhances SystemTextJsonContentSerializer initialization.

What is the current behavior?
To enchance a default SystemTextJsonContentSerializer behavior (e.g. add/remove converters) it is required to create a new JsonSerializerOptions instance and initialize it the same way it is initialized in SystemTextJsonContentSerializer constructor (copy/pasting), then additional options can be added.

What is the new behavior?
A user can create a JsonSerializerOptions initialized with defaults by calling SystemTextJsonContentSerializer.GetDefaultJsonSerializerOptions() extend it and use for SystemTextJsonContentSerializer initialization.

What might this PR break?
Not a breaking change.

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

related to #1217

@dnfadmin
Copy link

dnfadmin commented Sep 4, 2021

CLA assistant check
All CLA requirements met.

@clairernovotny clairernovotny merged commit 39553f2 into reactiveui:main Sep 4, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants