fix: load content into buffer for void return methods #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@lotz can you please sign the CLA by using the link in the previous comment so we can accept this PR? |
|
Yep, apologies for the delay. I am just checking the CLA language with my company's legal dept. Shouldn't be too much longer. Thanks! |
|
@clairernovotny all good, CLA signed. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
It fixes another code path related to the bug detailed in #1099.
What is the current behavior?
When a Refit interface method returns
Taskrather thanTask<T>, the[Body(buffered: true)]attribute is ignored.What is the new behavior?
Now void return interface methods will correctly buffer body content when specified in the Refit interface method signature.
What might this PR break?
It could break how POST/PUT bodies are serialized in requests.
Please check if the PR fulfills these requirements
Docs have been added / updated (for bug fixes / features)-- I believe the docs are already correct for how to usebuffered: true.Other information: