Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RestMethodInfo in HttpRequestMessage (Options or Properties) #1352

Merged

Conversation

Int32Overflow
Copy link
Contributor

What kind of change does this PR introduce?
Feature

What is the current behavior?
No RestMethodInfo is available in the HttpMessageHandler

What is the new behavior?
RestMethodInfo is now available in the HttpMessageHandler. Parameter-Name: RestMethodInfo { get; } = "Refit.RestMethodInfo";

What might this PR break?
Nothing

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@Int32Overflow
Copy link
Contributor Author

Same as #1317

@glennawatson glennawatson merged commit c97fcb6 into reactiveui:main Apr 12, 2023
@0xced
Copy link
Contributor

0xced commented Apr 12, 2023

My implementation of the same feature (#1317) was a little bit more complete with strongly typed HttpRequestOptionsKey and with updates to the README. Maybe you should also consider merging it.

@ChrisPulman
Copy link
Member

My implementation of the same feature (#1317) was a little bit more complete with strongly typed HttpRequestOptionsKey and with updates to the README. Maybe you should also consider merging it.

Thank you, we will take a look at this too, we're trying to get everything back in order and we will look at all the PRs in good time. Thank you for your efforts and patience.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants