Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HttpRequestMessageOptions to RefitSettings and add this dictionary to HttpRequestMessage.(Options/Properties) #1353

Merged
merged 5 commits into from
Apr 12, 2023

Conversation

Int32Overflow
Copy link
Contributor

What kind of change does this PR introduce?
Feature => Additional information can be passed to the HttpMessageHandler.

What is the new behavior?

  • In RefitSettings a new propety HttpRequestMessageOptions from type Dicationary<string,object> added
  • This values are filled in HttpRequestMessage.Properties or HttpRequestMessage.Options

What might this PR break?
Nothing

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

…y to HttpRequestMessage.(Options/Properties)

Add Unit Test
@james-s-tayler
Copy link
Contributor

I'm curious what use case this solves that isn't already covered by either using the [Property] attribute which lets you do exactly this, or by writing a custom DelegatingHandler that can inject some properties?

@glennawatson glennawatson enabled auto-merge (squash) April 12, 2023 07:46
@ChrisPulman ChrisPulman changed the title Pass through HttpRequestMessage.Options from RefitSettings Add HttpRequestMessageOptions to RefitSettings and add this dictionary to HttpRequestMessage.(Options/Properties) Apr 12, 2023
@ChrisPulman ChrisPulman enabled auto-merge (squash) April 12, 2023 08:38
@ChrisPulman ChrisPulman merged commit c1516a8 into reactiveui:main Apr 12, 2023
1 check passed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants