Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update readme with details on supply a custom HttpClient instance #1362

Merged
merged 2 commits into from
Apr 12, 2023
Merged

fix: Update readme with details on supply a custom HttpClient instance #1362

merged 2 commits into from
Apr 12, 2023

Conversation

chowarth
Copy link
Contributor

What kind of change does this PR introduce?

Readme update to include a description of supplying a custom HttpClient instance along with a potential pitfall and solution.

What is the current behavior?

#1240

What is the new behavior?

N/A

What might this PR break?
N/A

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@glennawatson glennawatson changed the title #1240 Update readme with details on supply a custom HttpClient instance fix: Update readme with details on supply a custom HttpClient instance Apr 12, 2023
@ChrisPulman ChrisPulman merged commit 25c4840 into reactiveui:main Apr 12, 2023
1 check passed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants