chore: run csharpier

[TimothyMakkison]

Ran csharpier 0.25.0, haven't made any other changes.

See #1596 & #1602

[codecov]

Codecov Report

Attention: 114 lines in your changes are missing coverage. Please review.

Comparison is base (bca7448) 85.40% compared to head (ad4b9fd) 87.85%.

Files	Patch %	Lines
Refit/RequestBuilderImplementation.cs	94.27%	15 Missing and 6 partials ⚠️
Refit/RestMethodInfo.cs	91.66%	14 Missing and 5 partials ⚠️
Refit.Xml/XmlContentSerializer.cs	72.91%	11 Missing and 2 partials ⚠️
Refit/Buffers/PooledBufferWriter.Stream.cs	0.00%	7 Missing and 5 partials ⚠️
Refit/Buffers/PooledBufferWriter.cs	21.42%	5 Missing and 6 partials ⚠️
...t.HttpClientFactory/HttpClientFactoryExtensions.cs	90.54%	4 Missing and 3 partials ⚠️
...Buffers/PooledBufferWriter.Stream.NETStandard21.cs	0.00%	6 Missing ⚠️
...Newtonsoft.Json/NewtonsoftJsonContentSerializer.cs	73.68%	4 Missing and 1 partial ⚠️
Refit/FormValueMultimap.cs	93.10%	0 Missing and 4 partials ⚠️
Refit/SystemTextJsonContentSerializer.cs	81.81%	1 Missing and 3 partials ⚠️
... and 8 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1617      +/-   ##
==========================================
+ Coverage   85.40%   87.85%   +2.44%     
==========================================
  Files          33       33              
  Lines        1685     2354     +669     
  Branches      295      295              
==========================================
+ Hits         1439     2068     +629     
- Misses        167      207      +40     
  Partials       79       79              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[anaisbetts]

I think we probably also want to set this up as a build tool? Running it Just Once doesn't really make much sense

[TimothyMakkison]

Good idea, I'm not the best at CI but I know how to run csharpier via husky if that's okay

[anaisbetts]

Paging @ChrisPulman @glennawatson who I bet have a great idea on how to do this

[glennawatson]

We can enforce the stylecop rules which probably be more useful long term. What we do on other rxui projects. Basically means it won't get out of control again.

Stylecop has the advantage of allowed exception etc.

[TimothyMakkison]

#1622 should automatically run csharpier on all commits. Not sure if you want csharpier if it isn't used in the other rxui projects. I'm happy to look into other solutions

[glennawatson]

I'd prefer we don't run the csharpier ever commit and we use stylecop analysers to maintain the styling. It has more flexibility then overriding deliberate style choices.

[TimothyMakkison]

Fair enough, as long as the solution removes the whitespace I'm happy 😊

[glennawatson]

Let's commit this one as a one time commit, I just don't want this running EVERY commit.

Sorry for the confusion.

[glennawatson]

Apologies, can you rerun the application on that failing file? Thanks.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.