Fixes "Misused header name" bug when using dynamic headers. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for existence of the header being removed in each headers collection before trying to remove it. (The headers collections throw if they don't support the named header.)
bennor
changed the title
anaisbetts
pushed a commit
that referenced
this pull request
Jun 30, 2014
Fixes "Misused header name" bug when using dynamic headers.
|
Thanks @bennor! |
|
No worries mate. Have to clean up my own messes ;) On Mon, Jun 30, 2014 at 8:21 PM, Paul Betts notifications@github.com
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #43.
It also fixes the equivalent bug with trying to remove a content header from the main headers collection.