Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for aliases in using directives. #62

Merged
merged 4 commits into from
Oct 19, 2014
Merged

Support for aliases in using directives. #62

merged 4 commits into from
Oct 19, 2014

Conversation

bennor
Copy link
Contributor

@bennor bennor commented Oct 19, 2014

This fixes #61.

Add a test that blows up when namespaces don't get aliased in generated
stubs.
@anaisbetts
Copy link
Member

@bennor How come this doesn't result in a change in RefitStubs.cs in the tests? Even though this is a generated file, I check it in so that we can see the history of the generated output (i.e. what was expected for that revision of the code)

@bennor
Copy link
Contributor Author

bennor commented Oct 19, 2014

I started out with a class that called RestService.For<INamespaceCollisionApi> (triggering the interface to be stubbed), but removed it because the code it was generating (before I added support for aliases) wouldn't compile, effectively breaking all of the tests.

I'm happy to add it back though, now support's been added.

@anaisbetts
Copy link
Member

@bennor Please do then this should be good to merge ✨

@bennor
Copy link
Contributor Author

bennor commented Oct 19, 2014

All done 😸

anaisbetts added a commit that referenced this pull request Oct 19, 2014
Support for aliases in using directives.
@anaisbetts anaisbetts merged commit c70eb74 into reactiveui:master Oct 19, 2014
@anaisbetts
Copy link
Member

Thanks @bennor!

@bennor bennor deleted the using-aliases branch October 20, 2014 03:31
@lock lock bot locked and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InterfaceStubGenerator causes namespace clash
2 participants