Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow spaces after attribute names. #74

Merged
merged 1 commit into from Nov 21, 2014
Merged

Allow spaces after attribute names. #74

merged 1 commit into from Nov 21, 2014

Conversation

bennor
Copy link
Contributor

@bennor bennor commented Nov 21, 2014

Using AttributeSyntax.ToFullString() was breaking detection of Refit attributes if there was a space between the attribute name and the bracket, because the "full" string includes trivia.

Replacing with AttributeSyntax.ToString() fixed that problem and didn't break any other tests so I think it's good.

Fixes #73.

Using `AttributeSyntax.ToFullString()` was breaking detection of Refit
attributes if there was a space between the attribute name and the
bracket, because the "full" string includes trivia.

Replacing with `AttributeSyntax.ToString()` fixed that problem and
didn't break any other tests so I think it's good.

Fixes #73.
@anaisbetts
Copy link
Member

Thanks @bennor! I don't know why I didn't think of it before, but I'm adding you as a collaborator to this repo so you can create PRs and manage them directly. All I ask is that you make PRs for non-trivial stuff, and don't merge PRs until I have a look at it

anaisbetts added a commit that referenced this pull request Nov 21, 2014
@anaisbetts anaisbetts merged commit 2410a4a into reactiveui:master Nov 21, 2014
@bennor
Copy link
Contributor Author

bennor commented Nov 21, 2014

Awesome, thanks :bowtie:

I'm not going to run wild with the code without talking to you about it first. 😉

Do I keep working on my fork or do I just work directly on branches of the main one? (Haven't been a collaborator on someone else's project before.)

@bennor bennor deleted the allow-spaces-after-attribute-names branch November 21, 2014 02:28
@anaisbetts
Copy link
Member

Do I keep working on my fork or do I just work directly on branches of the main one?

You can do either one, though now you can create branches directly on this repo, then create PRs that merge from my_feature_branch to master, without a fork.

The advantage of the latter approach, is that I can directly commit to branches in this repo, if we want to work together on a feature (i.e. if I want to make some change to your PR then give you a chance to read it before merging)

@bennor
Copy link
Contributor Author

bennor commented Nov 21, 2014

Cool. Will do that then. 😸

@lock lock bot locked and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stub implementations not created with pre-paren attribute whitespace
2 participants