Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Added Splat adapter tests #309

Merged
merged 1 commit into from
Mar 27, 2019
Merged

housekeeping: Added Splat adapter tests #309

merged 1 commit into from
Mar 27, 2019

Conversation

RLittlesII
Copy link
Member

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Resolves: #287

  • Added additional Autofac tests
  • Added additional DryIoc tests
  • Made DryIocDependencyResolver methods virtual

What might this PR break?

DryIoc Adapter

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

- Added additional Autofac tests
- Added additional DryIoc tests
- Made DryIocDependencyResolver methods virtual
@RLittlesII RLittlesII requested a review from a team March 27, 2019 09:40
@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #309 into master will increase coverage by 0.42%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #309      +/-   ##
==========================================
+ Coverage   70.18%   70.61%   +0.42%     
==========================================
  Files          61       61              
  Lines        3515     3515              
  Branches      312      312              
==========================================
+ Hits         2467     2482      +15     
+ Misses       1007      992      -15     
  Partials       41       41
Impacted Files Coverage Δ
src/Splat.DryIoc/DryIocDependencyResolver.cs 56.25% <100%> (+34.37%) ⬆️
.../Splat/ServiceLocation/DependencyResolverMixins.cs 72% <0%> (+4%) ⬆️
src/Splat.Autofac/AutofacDependencyResolver.cs 41.17% <0%> (+5.88%) ⬆️
src/Splat.Autofac/SplatAutofacExtensions.cs 100% <0%> (+50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c416dc...a66c158. Read the comment docs.

@glennawatson glennawatson merged commit fcdc148 into master Mar 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the tests branch March 27, 2019 10:42
@lock lock bot locked and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add additional tests to Splat Adapters
2 participants