Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for UWP Platform Bitmap Loader #600

Merged
merged 3 commits into from
Oct 8, 2020
Merged

Fixes for UWP Platform Bitmap Loader #600

merged 3 commits into from
Oct 8, 2020

Conversation

dpvreony
Copy link
Member

@dpvreony dpvreony commented Oct 4, 2020

What kind of change does this PR introduce?

Bug fixes for UWP. Adds XUnit Test runner

Closes #478 (was already closed, the ticket is mixed up with #479)
Closes #519

What is the current behavior?
Thread Marshalling issue on Create Bitmap

What is the new behavior?
Uses UWP dispatcher, but needs double check as it uses GetAwaiter().GetResult();

What might this PR break?
n/a

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@dpvreony dpvreony requested a review from a team October 4, 2020 22:28
@glennawatson glennawatson merged commit a2cadff into main Oct 8, 2020
@glennawatson glennawatson deleted the uwptestrunner branch October 8, 2020 01:15
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] UWP Bitmap create threading exception [BUG] PlatformBitmapLoader throws System.NotSupportedException
2 participants