Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update index.md #120

Merged
merged 5 commits into from Aug 3, 2018
Merged

Update index.md #120

merged 5 commits into from Aug 3, 2018

Conversation

StoneWolf
Copy link
Contributor

@StoneWolf StoneWolf commented Jun 28, 2018 •
edited

Fix typos/grammar.

@StoneWolf
Update index.md
fcd495e 
Fix typos/grammar
@dnfclas
Copy link

dnfclas commented Jun 28, 2018 •
edited

CLA assistant check
All CLA requirements met.

glennawatson
glennawatson requested changes Jun 28, 2018
View reviewed changes
input/docs/getting-started/index.md Outdated
@@ -17,7 +17,7 @@ Let's create a simple application demonstrating a number of ReactiveUI functiona
We will create a WPF application, which will allow us to search through Flickr public images.
The full code of the application is shown at the end of this chapter, and we will show relevant snippets as we go.

In Visual Studio create a new WPF application (.Net 4.5 or above)
In Visual Studio, create a new WPF application (.NET 4.5 or above).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we increased that to like 4.6.1 now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/reactiveui/ReactiveUI/blob/f2290c290f189ab349dcdae0a5cc752a69fb06f7/src/ReactiveUI.Wpf/ReactiveUI.Wpf.csproj#L9

Seems like it!

@glennawatson glennawatson requested review from a team June 28, 2018 13:03
olevett
olevett reviewed Jun 28, 2018
View reviewed changes
Copy link
Member

@olevett olevett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, other than the 461 point 👍

@glennawatson
Copy link
Contributor

@onovotny Is there an issue with that builder? Eg the website PR validation task failed with a time out.

@clairernovotny
Copy link
Member

Two things:

  1. I don't see a vsts yaml file checked in anywere...it really should be for the build
  2. The publish step needs a condition and(succeeded(), eq(variables['system.pullrequest.isfork'], false)) because forks cannot publish artifacts currently.

@glennawatson glennawatson mentioned this pull request Jul 21, 2018
Closed
@glennawatson glennawatson merged commit 83d7ee3 into reactiveui:master Aug 3, 2018
@lock lock bot locked and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@olevett olevett olevett left review comments

@glennawatson glennawatson glennawatson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@StoneWolf @dnfclas @glennawatson @clairernovotny @olevett