-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Android SDK dependencies #83
Comments
Yes. Related to what will be done for #74. |
This has multiple blockers. First one being nebula-plugins/gradle-rxjava-project-plugin#6. |
There's also this horrible transitive dependency on Spock which uses Groovy version-specific artifacts (cue facepalm) so we have to do gross shit like this to force the right version: configurations.classpath.resolutionStrategy {
// The 'nebula-test' plugin depends on Spock which is Groovy version specific (gross!). Explicitly
// force the version which matches our Groovy version.
eachDependency { DependencyResolveDetails details ->
if (details.requested.name == 'spock-core') {
details.useTarget group: details.requested.group, name: details.requested.name, version: '0.7-groovy-2.0'
}
}
} |
I'm not sure I understand how turning this into an Android library project relates to being able to use the support-library JARs. Is that because we'd have to apply the Android/Gradle plugin to the core library? Could we add the local SDK repositories to the build scripts instead to perform that lookup? At least as a temporary solution. I don't see why the library has to be or should be an AAR. The |
Being an 'aar' affords us:
I said on some other issue that we can still publish the 'jar' version for legacy builds. |
That's good points there. Agreed then. |
Resolved by #189. |
Taking off from this discussion, it would be nice if this lib supported Android's support annotations.
At this point, though, we don't actually depend on any of the local repositories that the SDK uses; it's just using the few Android libs floating around in jcenter (which are rather out of date). This keeps the library simpler but limits our ability to add more recent support libraries.
Thoughts? Should we just embrace the local m2 repo?
The text was updated successfully, but these errors were encountered: