Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error "Could not find implementations of custom rules" #16

Closed
mark-langer opened this issue Apr 20, 2018 · 8 comments
Closed

Error "Could not find implementations of custom rules" #16

mark-langer opened this issue Apr 20, 2018 · 8 comments

Comments

@mark-langer
Copy link

mark-langer commented Apr 20, 2018

Hi team,

the idea for the package is great! I cannot get it to work though following the steps in the migration guide though.

After installing rxjs-tslint, adding the file migrate-rxjs.tslint.json and running the command ./node_modules/.bin/tslint -c migrate-rxjs.tslint.json --project src/tsconfig.app.json --fix I get the following error:

`Could not find implementations for the following rules specified in the configuration:
update-rxjs-imports
migrate-to-pipeable-operators
migrate-static-observable-methods
collapse-rxjs-imports
Try upgrading TSLint and/or ensuring that you have all necessary custom rules installed.
If TSLint was recently upgraded, you may have old rules configured which need to be cleaned up.

No valid rules have been specified`

Am I doing something wrong or is this a bug within the package? I tried uninstalling TSLint, delete the global rules file and re-install it. But to no avail. I even tried removing all rules from that TSLint file to test if any of them is corrupted.

There is a folder at node_modules/rxjs-tslint. It looks like this:
image

tslint@5.9.1
rxjs-tslint@0.1.0

@euangoddard
Copy link

euangoddard commented Apr 20, 2018

I'm getting this error too for the same versions. I managed to successfully run this the other day, and I'm pretty sure it was the same version of tslint

One thing I noticed is that in the node_modules folder for the project there is a file called migration-tslint.json and the rulesDirectory key doesn't match any path. Is this a packaging error?

Downgrading rxjs-migrate to 0.0.0 doesn't give this error (only complains that migrate-static-observable-methods is missing, but I guess this may not have been implemented in that release).

@mgechev
Copy link
Collaborator

mgechev commented Apr 20, 2018

Will take a look today.

@mgechev
Copy link
Collaborator

mgechev commented Apr 20, 2018

In 0.1.1 everything should be working fine.

@mgechev mgechev closed this as completed Apr 20, 2018
@euangoddard
Copy link

Thanks for looking into this especially given that you were at ng-conf!

@iget-master
Copy link

I'm still having this issue.

$ ./node_modules/.bin/tslint -c migrate-rxjs.tslint.json --project src/tsconfig.app.json --fix

Could not find implementations for the following rules specified in the configuration:
    rxjs-proper-imports
    rxjs-pipeable-operators-only
    rxjs-no-static-observable-methods
    rxjs-collapse-imports
Try upgrading TSLint and/or ensuring that you have all necessary custom rules installed.
If TSLint was recently upgraded, you may have old rules configured which need to be cleaned up.
        
No valid rules have been specified

@mgechev
Copy link
Collaborator

mgechev commented Apr 24, 2018

What version of rxjs-tslint are you using?

@iget-master
Copy link

"rxjs-tslint": "^0.1.1",

@iget-master
Copy link

Solved the problem. I was following some angular or rxjs doc that was telling to call the rxjs-tslint from project node_modules instead of the global rxjs-5-to-6-migrate command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants