Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

endWith should widen the type if necessary #4183

Closed
cartant opened this issue Sep 25, 2018 · 3 comments
Closed

endWith should widen the type if necessary #4183

cartant opened this issue Sep 25, 2018 · 3 comments
Labels
help wanted Issues we wouldn't mind assistance with. TS Issues and PRs related purely to TypeScript issues

Comments

@cartant
Copy link
Collaborator

cartant commented Sep 25, 2018

Feature Request

startWith can be passed values other than T and if that's done, the operator's return type is widened. See #4034.

endWith needs to be treated similarly and needs an additional dtslint test, etc.
@cartant
Copy link
Collaborator Author

cartant commented Sep 25, 2018

@dkosasih If you want to handle this, that would be great.

@kwonoj kwonoj added help wanted Issues we wouldn't mind assistance with. TS Issues and PRs related purely to TypeScript issues labels Sep 25, 2018
@timdeschryver
Copy link
Contributor

Feel free to ping me if you need to verify something @dkosasih

dkosasih added a commit to dkosasih/rxjs that referenced this issue Sep 25, 2018
@dkosasih
fix(endWith): ability to endWith different types (ReactiveX#4183)
d08f235
@dkosasih dkosasih mentioned this issue Sep 25, 2018
Merged
benlesh pushed a commit that referenced this issue Oct 10, 2018
@dkosasih @benlesh
fix(endWith): ability to endWith different types (#4183) (#4185)
83533d1
@cartant
Copy link
Collaborator Author

cartant commented Jan 27, 2019

A PR for this has been merged.

@cartant cartant closed this as completed Jan 27, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted Issues we wouldn't mind assistance with. TS Issues and PRs related purely to TypeScript issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kwonoj @cartant @timdeschryver