fix: remove misused type parameter from isObservable #6083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartant
force-pushed
the
cartant/is-observable
branch
from
37f5432
to
427a6db
Compare
benlesh
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR removes a misused type parameter from
isObservable. The type parameterTis misused because there's no way it can be inferred; it's nothing more than a type assertion. There is no wayisObservablecan know the element type of any value that it deems to be anObservable, so it should returnObservable<unknown>. IMO, we should not be encouraging devs to write unsafe code.BREAKING CHANGE:
isObservablereturnsis Observable<unknown>and no longer accepts a type parameter.Related issue (if exists): Nope