Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix reexports to be SystemJS compatible after transpilation #3406

Merged
merged 1 commit into from Mar 8, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions spec/systemjs-compatibility-spec.ts
@@ -0,0 +1,7 @@
// all these imports verify that our ESM imports and exports are SystemJS compatible after transpilation
// this is done by relying on the tsc type-checker configured with "moduleResolution" set to "classic"
import * as rxjs from '../src/index';
import * as rxjsAjax from '../src/ajax';
import * as rxjsOperators from '../src/operators';
import * as rxjsTesting from '../src/testing';
import * as rxjsWebsocket from '../src/websocket';
1 change: 1 addition & 0 deletions src/ajax.ts
@@ -0,0 +1 @@
export * from './ajax/index';
2 changes: 1 addition & 1 deletion src/internal/Rx.ts
Expand Up @@ -176,7 +176,7 @@ import { rxSubscriber } from './symbol/rxSubscriber';
import { iterator } from './symbol/iterator';
import { observable } from './symbol/observable';

import * as _operators from './operators';
import * as _operators from './operators/index';

export const operators = _operators;

Expand Down
1 change: 1 addition & 0 deletions src/operators.ts
@@ -0,0 +1 @@
export * from './operators/index';
1 change: 1 addition & 0 deletions src/testing.ts
@@ -0,0 +1 @@
export * from './testing/index';
1 change: 1 addition & 0 deletions src/websocket.ts
@@ -0,0 +1 @@
export * from './websocket/index';
2 changes: 1 addition & 1 deletion tsconfig.json
Expand Up @@ -8,7 +8,7 @@
"noImplicitReturns": true,
"noImplicitThis": true,
"suppressImplicitAnyIndexErrors": true,
"moduleResolution": "node",
"moduleResolution": "classic", // we intentionally use "classic" module resolution to be SystemJS-compatible after transpilation
"stripInternal": true,
"target": "es5",
"outDir": "./.out",
Expand Down