Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(debounce-spec): update debounce operator tests to use pipeable operators #3660

Merged
merged 1 commit into from
May 8, 2018
Merged

refactor(debounce-spec): update debounce operator tests to use pipeable operators #3660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
135 changes: 71 additions & 64 deletions spec/operators/debounce-spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,26 @@
import { expect } from 'chai';
import * as Rx from 'rxjs/Rx';
import { NEVER, timer, of, EMPTY, concat, Subject, Observable } from 'rxjs';
import { debounce, mergeMap, mapTo } from 'rxjs/operators';
import { TestScheduler } from 'rxjs/testing';
import { hot, cold, expectObservable, expectSubscriptions } from '../helpers/marble-testing';
import { NEVER } from 'rxjs';

declare const type;
declare function asDiagram(arg: string): Function;

declare const rxTestScheduler: Rx.TestScheduler;
const Observable = Rx.Observable;
declare const rxTestScheduler: TestScheduler;

/** @test {debounce} */
describe('Observable.prototype.debounce', () => {
describe('debounce operator', () => {
function getTimerSelector(x) {
return () => Observable.timer(x, rxTestScheduler);
return () => timer(x, rxTestScheduler);
}

asDiagram('debounce')('should debounce values by a specified cold Observable', () => {
const e1 = hot('-a--bc--d---|');
const e2 = cold('--| ');
const expected = '---a---c--d-|';

const result = e1.debounce(() => e2);
const result = e1.pipe(debounce(() => e2));

expectObservable(result).toBe(expected);
});
Expand All @@ -30,7 +30,7 @@ describe('Observable.prototype.debounce', () => {
const e1subs = '^ !';
const expected = '----a--b--c--d-------|';

expectObservable(e1.debounce(getTimerSelector(20))).toBe(expected);
expectObservable(e1.pipe(debounce(getTimerSelector(20)))).toBe(expected);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

Expand All @@ -39,7 +39,7 @@ describe('Observable.prototype.debounce', () => {
const e1subs = '^ !';
const expected = '----a---c--d--|';

expectObservable(e1.debounce(getTimerSelector(20))).toBe(expected);
expectObservable(e1.pipe(debounce(getTimerSelector(20)))).toBe(expected);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

Expand All @@ -52,7 +52,7 @@ describe('Observable.prototype.debounce', () => {
const e1subs = '^ !';
const expected = '--a--bc--d----|';

expectObservable(e1.debounce(() => Rx.Observable.of(0))).toBe(expected);
expectObservable(e1.pipe(debounce(() => of(0)))).toBe(expected);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

Expand All @@ -61,7 +61,7 @@ describe('Observable.prototype.debounce', () => {
const e1subs = '^ !';
const expected = '-----|';

expectObservable(e1.debounce(getTimerSelector(20))).toBe(expected);
expectObservable(e1.pipe(debounce(getTimerSelector(20)))).toBe(expected);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

Expand All @@ -70,7 +70,7 @@ describe('Observable.prototype.debounce', () => {
const e1subs = '(^!)';
const expected = '|';

expectObservable(e1.debounce(getTimerSelector(20))).toBe(expected);
expectObservable(e1.pipe(debounce(getTimerSelector(20)))).toBe(expected);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

Expand All @@ -79,7 +79,7 @@ describe('Observable.prototype.debounce', () => {
const e1subs = '^ !';
const expected = '-----#';

expectObservable(e1.debounce(getTimerSelector(20))).toBe(expected);
expectObservable(e1.pipe(debounce(getTimerSelector(20)))).toBe(expected);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

Expand All @@ -88,7 +88,7 @@ describe('Observable.prototype.debounce', () => {
const e1subs = '(^!)';
const expected = '#';

expectObservable(e1.debounce(getTimerSelector(20))).toBe(expected);
expectObservable(e1.pipe(debounce(getTimerSelector(20)))).toBe(expected);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

Expand All @@ -98,7 +98,7 @@ describe('Observable.prototype.debounce', () => {
const expected = '----a--- ';
const unsub = ' ! ';

const result = e1.debounce(getTimerSelector(20));
const result = e1.pipe(debounce(getTimerSelector(20)));

expectObservable(result, unsub).toBe(expected);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
Expand All @@ -110,10 +110,11 @@ describe('Observable.prototype.debounce', () => {
const expected = '----a--- ';
const unsub = ' ! ';

const result = e1
.mergeMap((x: any) => Observable.of(x))
.debounce(getTimerSelector(20))
.mergeMap((x: any) => Observable.of(x));
const result = e1.pipe(
mergeMap((x: any) => of(x)),
debounce(getTimerSelector(20)),
mergeMap((x: any) => of(x))
);

expectObservable(result, unsub).toBe(expected);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
Expand All @@ -124,7 +125,7 @@ describe('Observable.prototype.debounce', () => {
const e1subs = '^ ';
const expected = '----a---c--d-';

expectObservable(e1.debounce(getTimerSelector(20))).toBe(expected);
expectObservable(e1.pipe(debounce(getTimerSelector(20)))).toBe(expected);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

Expand All @@ -133,7 +134,7 @@ describe('Observable.prototype.debounce', () => {
const e1subs = '^';
const expected = '-';

expectObservable(e1.debounce(getTimerSelector(20))).toBe(expected);
expectObservable(e1.pipe(debounce(getTimerSelector(20)))).toBe(expected);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

Expand All @@ -142,7 +143,7 @@ describe('Observable.prototype.debounce', () => {
const e1subs = '^';
const expected = '-';

expectObservable(e1.debounce(getTimerSelector(20))).toBe(expected);
expectObservable(e1.pipe(debounce(getTimerSelector(20)))).toBe(expected);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

Expand All @@ -151,7 +152,7 @@ describe('Observable.prototype.debounce', () => {
const e1subs = '^ !';
const expected = '----a--b--c--d-------#';

expectObservable(e1.debounce(getTimerSelector(20))).toBe(expected);
expectObservable(e1.pipe(debounce(getTimerSelector(20)))).toBe(expected);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

Expand All @@ -160,7 +161,7 @@ describe('Observable.prototype.debounce', () => {
const e1subs = '^ !';
const expected = '--------------------(e|)';

expectObservable(e1.debounce(getTimerSelector(40))).toBe(expected);
expectObservable(e1.pipe(debounce(getTimerSelector(40)))).toBe(expected);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

Expand All @@ -169,7 +170,7 @@ describe('Observable.prototype.debounce', () => {
const e1subs = '^ !';
const expected = '-------------#';

expectObservable(e1.debounce(getTimerSelector(50))).toBe(expected);
expectObservable(e1.pipe(debounce(getTimerSelector(50)))).toBe(expected);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

Expand All @@ -185,7 +186,7 @@ describe('Observable.prototype.debounce', () => {
' ^ ! ',
' ^ ! '];

expectObservable(e1.debounce(() => selector)).toBe(expected);
expectObservable(e1.pipe(debounce(() => selector))).toBe(expected);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
expectSubscriptions(selector.subscriptions).toBe(selectorSubs);
});
Expand All @@ -206,7 +207,7 @@ describe('Observable.prototype.debounce', () => {
' ^ ! ',
' ^ ! '];

expectObservable(e1.debounce(() => selector.shift())).toBe(expected);
expectObservable(e1.pipe(debounce(() => selector.shift()))).toBe(expected);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
for (let i = 0; i < selectorSubs.length; i++) {
expectSubscriptions(selector[i].subscriptions).toBe(selectorSubs[i]);
Expand All @@ -229,7 +230,7 @@ describe('Observable.prototype.debounce', () => {
' ^ ! ',
' ^!'];

expectObservable(e1.debounce(() => selector.shift())).toBe(expected);
expectObservable(e1.pipe(debounce(() => selector.shift()))).toBe(expected);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
for (let i = 0; i < selectorSubs.length; i++) {
expectSubscriptions(selector[i].subscriptions).toBe(selectorSubs[i]);
Expand All @@ -248,7 +249,7 @@ describe('Observable.prototype.debounce', () => {
' ^ ! ',
' ^ !'];

expectObservable(e1.debounce(() => selector.shift())).toBe(expected);
expectObservable(e1.pipe(debounce(() => selector.shift()))).toBe(expected);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
for (let i = 0; i < selectorSubs.length; i++) {
expectSubscriptions(selector[i].subscriptions).toBe(selectorSubs[i]);
Expand All @@ -269,7 +270,7 @@ describe('Observable.prototype.debounce', () => {
' ^ ! ',
' ^!'];

expectObservable(e1.debounce(() => selector.shift())).toBe(expected);
expectObservable(e1.pipe(debounce(() => selector.shift()))).toBe(expected);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
for (let i = 0; i < selectorSubs.length; i++) {
expectSubscriptions(selector[i].subscriptions).toBe(selectorSubs[i]);
Expand All @@ -294,7 +295,7 @@ describe('Observable.prototype.debounce', () => {
}
}

expectObservable(e1.debounce(selectorFunction)).toBe(expected);
expectObservable(e1.pipe(debounce(selectorFunction))).toBe(expected);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
for (let i = 0; i < selectorSubs.length; i++) {
expectSubscriptions(selector[i].subscriptions).toBe(selectorSubs[i]);
Expand All @@ -306,9 +307,9 @@ describe('Observable.prototype.debounce', () => {
const e1subs = '^ !';
const expected = '--------a-x-yz---bxy---z--c--x--y--z|';

function selectorFunction(x) { return Observable.empty<number>(); }
function selectorFunction(x) { return EMPTY; }

expectObservable(e1.debounce(selectorFunction)).toBe(expected);
expectObservable(e1.pipe(debounce(selectorFunction))).toBe(expected);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

Expand All @@ -319,7 +320,7 @@ describe('Observable.prototype.debounce', () => {

function selectorFunction() { return NEVER; }

expectObservable(e1.debounce(selectorFunction)).toBe(expected);
expectObservable(e1.pipe(debounce(selectorFunction))).toBe(expected);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

Expand All @@ -335,7 +336,7 @@ describe('Observable.prototype.debounce', () => {
' ^ ! ',
' ^ ! '];

expectObservable(e1.debounce(() => selector.shift())).toBe(expected);
expectObservable(e1.pipe(debounce(() => selector.shift()))).toBe(expected);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
for (let i = 0; i < selectorSubs.length; i++) {
expectSubscriptions(selector[i].subscriptions).toBe(selectorSubs[i]);
Expand All @@ -358,24 +359,27 @@ describe('Observable.prototype.debounce', () => {
' ^! ',
' ^ ! '];

expectObservable(e1.debounce(() => selector.shift())).toBe(expected);
expectObservable(e1.pipe(debounce(() => selector.shift()))).toBe(expected);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
for (let i = 0; i < selectorSubs.length; i++) {
expectSubscriptions(selector[i].subscriptions).toBe(selectorSubs[i]);
}
});

it('should delay by promise resolves', (done: MochaDone) => {
const e1 = Observable.concat(Observable.of(1),
Observable.timer(10).mapTo(2),
Observable.timer(10).mapTo(3),
Observable.timer(100).mapTo(4)
);
const e1 = concat(
of(1),
timer(10).pipe(mapTo(2)),
timer(10).pipe(mapTo(3)),
timer(100).pipe(mapTo(4))
);
const expected = [1, 2, 3, 4];

e1.debounce(() => {
return new Promise((resolve: any) => { resolve(42); });
}).subscribe((x: number) => {
e1.pipe(
debounce(() => {
return new Promise((resolve: any) => { resolve(42); });
})
).subscribe((x: number) => {
expect(x).to.equal(expected.shift()); },
(x) => {
done(new Error('should not be called'));
Expand All @@ -387,21 +391,24 @@ describe('Observable.prototype.debounce', () => {
});

it('should raises error when promise rejects', (done: MochaDone) => {
const e1 = Observable.concat(Observable.of(1),
Observable.timer(10).mapTo(2),
Observable.timer(10).mapTo(3),
Observable.timer(100).mapTo(4)
);
const e1 = concat(
of(1),
timer(10).pipe(mapTo(2)),
timer(10).pipe(mapTo(3)),
timer(100).pipe(mapTo(4))
);
const expected = [1, 2];
const error = new Error('error');

e1.debounce((x: number) => {
if (x === 3) {
return new Promise((resolve: any, reject: any) => { reject(error); });
} else {
return new Promise((resolve: any) => { resolve(42); });
}
}).subscribe((x: number) => {
e1.pipe(
debounce((x: number) => {
if (x === 3) {
return new Promise((resolve: any, reject: any) => { reject(error); });
} else {
return new Promise((resolve: any) => { resolve(42); });
}
})
).subscribe((x: number) => {
expect(x).to.equal(expected.shift()); },
(err: any) => {
expect(err).to.be.an('error', 'error');
Expand All @@ -414,9 +421,9 @@ describe('Observable.prototype.debounce', () => {

it('should debounce correctly when synchronously reentered', () => {
const results = [];
const source = new Rx.Subject();
const source = new Subject();

source.debounce(() => Observable.of(null)).subscribe(value => {
source.pipe(debounce(() => of(null))).subscribe(value => {
results.push(value);

if (value === 1) {
Expand All @@ -430,17 +437,17 @@ describe('Observable.prototype.debounce', () => {

type('should support selectors of the same type', () => {
/* tslint:disable:no-unused-variable */
let o: Rx.Observable<number>;
let s: Rx.Observable<number>;
let r: Rx.Observable<number> = o.debounce((n) => s);
let o: Observable<number>;
let s: Observable<number>;
let r: Observable<number> = o.pipe(debounce((n) => s));
/* tslint:enable:no-unused-variable */
});

type('should support selectors of a different type', () => {
/* tslint:disable:no-unused-variable */
let o: Rx.Observable<number>;
let s: Rx.Observable<string>;
let r: Rx.Observable<number> = o.debounce((n) => s);
let o: Observable<number>;
let s: Observable<string>;
let r: Observable<number> = o.pipe(debounce((n) => s));
/* tslint:enable:no-unused-variable */
});
});