Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support of the JavaScript Engine Switcher version 3.0.0 Beta and JSPool version 3.1.0 Beta 1 #551

Merged
merged 1 commit into from Jun 29, 2018

Conversation

Taritsyn
Copy link
Contributor

Hello!

JavaScript Engine Switcher version 3.X has moved to the stabilization phase. I think that it's time to release beta version of the ReactJS.NET.

Main changes you can find in the “How to upgrade applications to version 3.X” section of documentation.

I removed the WrapJavaScriptRuntimeException method, because it was no longer necessary. JavaScript Engine Switcher version 3.X now provides information about error location in the message:

------------------------------------------------------------
ChakraCoreJsEngine
------------------------------------------------------------
ReferenceError: 'n' is not defined
   at f (doc01.js:9:3) ->               n();
   at Global code (doc01.js:1:1)

------------------------------------------------------------
JintJsEngine
------------------------------------------------------------
ReferenceError: n is not defined
   at doc01.js:9:3

------------------------------------------------------------
JurassicJsEngine
------------------------------------------------------------
ReferenceError: n is not defined
   at f (doc01.js:9)
   at Global code (doc01.js:1)

------------------------------------------------------------
MsieJsEngine
------------------------------------------------------------
ReferenceError: 'n' is undefined
   at f (doc01.js:9:3)
   at Global code (doc01.js:1:1)

------------------------------------------------------------
NiLJsEngine
------------------------------------------------------------
ReferenceError: Variable "n" is not defined
   at 9:3 ->            n();

------------------------------------------------------------
V8JsEngine
------------------------------------------------------------
ReferenceError: n is not defined
   at f (doc01.js:9:3) ->               n();
   at doc01.js:1:1

------------------------------------------------------------
VroomJsEngine
------------------------------------------------------------
ReferenceError: n is not defined
   at doc01.js:9:3

@dustinsoftware
Copy link
Member

Thanks!! This might also be a good time to remove the references to Vroom, Chakra, etc from React.Core, and have users register their own JS engines.

@Taritsyn
Copy link
Contributor Author

Hello, Dustin!

Good idea, but it is better to implement it in a separate PR.

@Daniel15
Copy link
Member

This looks pretty good to me! @dustinsoftware, what do you think? Any other changes we should make, or should we merge it?

Copy link
Member

@dustinsoftware dustinsoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, let's merge and get a beta shipped

@dustinsoftware dustinsoftware merged commit 79ca155 into reactjs:master Jun 29, 2018
@Daniel15
Copy link
Member

Daniel15 commented Jul 1, 2018

Shipped in 4.0-beta1 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants