Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate refs-and-the-dom #108

Merged
merged 9 commits into from Jun 25, 2019
Merged

Conversation

mohshbool
Copy link
Member

translated Refs and the dom page

@netlify
Copy link

netlify bot commented Jun 23, 2019

Deploy preview for ar-reactjs ready!

Built with commit 70eb002

https://deploy-preview-108--ar-reactjs.netlify.com

Copy link
Collaborator

@Fcmam5 Fcmam5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @mohshbool for your contribution, mashaa Allah you did a very good job.
Please allow me to add some suggestions & corrections so we get closer to the perfection with this clean PR.

Also, as a suggestion when adding the original English word to clarify your translation, make it in parentheses as the wiki suggest

content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
mohshbool and others added 7 commits June 24, 2019 12:45
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@mohshbool
Copy link
Member Author

@Fcmam5 thank you so much for your kind words and your valuable suggestions that I managed to miss because I was just too focused on getting this repo to 70% so that it's available as an official language on the actual website. I can't thank enough for those great suggestions

@iRayan7 iRayan7 merged commit cddab9e into reactjs:master Jun 25, 2019
@mohshbool mohshbool deleted the refs-and-the-dom branch June 27, 2019 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants