Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Done] translate community/support (related to #117) #113

Merged
merged 2 commits into from Jun 28, 2019

Conversation

Fcmam5
Copy link
Collaborator

@Fcmam5 Fcmam5 commented Jun 27, 2019

Related to #117

@Fcmam5 Fcmam5 changed the title [Work in progress] translate community page [Work in progress] translate community pages Jun 27, 2019
@netlify
Copy link

netlify bot commented Jun 27, 2019

Deploy preview for ar-reactjs ready!

Built with commit 5c37fd0

https://deploy-preview-113--ar-reactjs.netlify.com

@3imed-jaberi
Copy link
Member

3imed-jaberi commented Jun 27, 2019

Hello @Fcmam5 ,

I think every page should be in one PR. Check out this with @iRayan7.
If this may be, i think you should rename this PR to [Work in progress] translate community section.
I will help here translate the rest together.

@Fcmam5 Fcmam5 changed the title [Work in progress] translate community pages [Work in progress] translate community section Jun 27, 2019
@Fcmam5
Copy link
Collaborator Author

Fcmam5 commented Jun 27, 2019

Hello @Fcmam5 ,
think every page should be in one PR. Check out this with @iRayan7.
If this may be, i think you should rename this PR to [Work in progress] translate community section.
I will help here translate the rest together.

You're right about the title, I thought that it was a simple page until I figured out that it was a complete section.
And sure, you are the most welcome to collaborate on this section, just reference #113 on your PRs, or let's follow any strategy the team chooses :)

@3imed-jaberi
Copy link
Member

Hello @Fcmam5 ,
think every page should be in one PR. Check out this with @iRayan7.
If this may be, i think you should rename this PR to [Work in progress] translate community section.
I will help here translate the rest together.

You're right about the title, I thought that it was a simple page until I figured out that it was a complete section.
And sure, you are the most welcome to collaborate on this section, just reference #113 on your PRs, or let's follow any strategy the team chooses :)

Awesome, let's wait for the strategy of the team to choose 🤝:heart:

@iRayan7

@iRayan7
Copy link
Member

iRayan7 commented Jun 27, 2019

Hi @Fcmam5 @3imed-jaberi, just created this issue for Community section #117 . Let us continue the assignment there.

@iRayan7
Copy link
Member

iRayan7 commented Jun 27, 2019

@Fcmam5 Please make this PR for the first page to close it 👍

@Fcmam5 Fcmam5 changed the title [Work in progress] translate community section [Done] translate community/support (related to #117) Jun 27, 2019
@iRayan7 iRayan7 merged commit 572c350 into reactjs:master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants