Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Done] translating versioning #116

Merged
merged 1 commit into from Jul 8, 2019

Conversation

maskeddeveloper
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Jun 27, 2019

Deploy preview for ar-reactjs ready!

Built with commit 88b194d

https://deploy-preview-116--ar-reactjs.netlify.com

@iRayan7
Copy link
Member

iRayan7 commented Jun 27, 2019

Hi @3imed-jaberi, please review this PR. Thanks.

Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @maskeddeveloper , thank you very much for you're effort in ar.reactjs community 😄 !
Please, I suggested some small fixes , file structure and a request to change an expression . Can you check it out?!

content/docs/faq-versioning.md Show resolved Hide resolved
content/docs/faq-versioning.md Show resolved Hide resolved
content/docs/faq-versioning.md Show resolved Hide resolved
content/docs/faq-versioning.md Show resolved Hide resolved
content/docs/faq-versioning.md Show resolved Hide resolved
@iRayan7 iRayan7 merged commit 54f2928 into reactjs:master Jul 8, 2019
@iRayan7 iRayan7 added approved and removed in-review labels Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants