Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DONE] hello-world.md .. #125

Merged
merged 11 commits into from Jul 26, 2019
Merged

[DONE] hello-world.md .. #125

merged 11 commits into from Jul 26, 2019

Conversation

maskeddeveloper
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Jul 2, 2019 •
edited

Deploy preview for ar-reactjs ready!

Built with commit 44a5980

https://deploy-preview-125--ar-reactjs.netlify.com

@3imed-jaberi
Copy link
Member

Hi @maskeddeveloper 👋 any updates on this?

@3imed-jaberi 3imed-jaberi added the update needed This PR needs update since last commit label Jul 21, 2019
@maskeddeveloper
Copy link
Contributor Author

@3imed-jaberi Today i'll commit

@maskeddeveloper
Copy link
Contributor Author

@3imed-jaberi it's done , i'm open for review.
Sorry to be so late, lot of wooork

@maskeddeveloper
Copy link
Contributor Author

@Aissaoui-Ahmed yes i did correct that, thanx for your comment

@maskeddeveloper maskeddeveloper changed the title [Work in progress] Hello World [DONE] Hello World Jul 23, 2019
@mohshbool mohshbool added in-review and removed update needed This PR needs update since last commit work-in-progress labels Jul 23, 2019
mohshbool
mohshbool requested changes Jul 23, 2019
View reviewed changes
Copy link
Member

@mohshbool mohshbool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job @maskeddeveloper
amazing work, really
please, allow me to make these suggestions, they're just small fixes

content/docs/hello-world.md Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
@mohshbool mohshbool added changes-requested update needed This PR needs update since last commit and removed in-review labels Jul 23, 2019
@maskeddeveloper
Copy link
Contributor Author

@moshbool i'll be making the changes ASAP

@3imed-jaberi 3imed-jaberi self-assigned this Jul 23, 2019
3imed-jaberi
3imed-jaberi requested changes Jul 23, 2019
View reviewed changes
Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job @maskeddeveloper ..
thanks you for your contribution in react community 🎖 ..

i will add this nano bug to the suggestions ..

content/docs/hello-world.md Outdated
@@ -11,7 +11,7 @@ next: introducing-jsx.html

```js
ReactDOM.render(
<h1>Hello, world!</h1>,
<h1>مرحبا بالعالم!</h1>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

أهلا بالعالم ✔️ ..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maskeddeveloper ,
لماذا لم تغيرها !

maskeddeveloper and others added 6 commits July 24, 2019 10:01
@maskeddeveloper @mohshbool
Update content/docs/hello-world.md
f9784cf 
Co-Authored-By: Mohammad Shbool <alshboolmoh@gmail.com>
@maskeddeveloper @mohshbool
Update content/docs/hello-world.md
b451a1c 
Co-Authored-By: Mohammad Shbool <alshboolmoh@gmail.com>
@maskeddeveloper @mohshbool
Update content/docs/hello-world.md
5379d3a 
Co-Authored-By: Mohammad Shbool <alshboolmoh@gmail.com>
@maskeddeveloper @mohshbool
Update content/docs/hello-world.md
00b70af 
Co-Authored-By: Mohammad Shbool <alshboolmoh@gmail.com>
@maskeddeveloper @mohshbool
Update content/docs/hello-world.md
ca9bb26 
Co-Authored-By: Mohammad Shbool <alshboolmoh@gmail.com>
@maskeddeveloper @mohshbool
Update content/docs/hello-world.md
fd57593 
Co-Authored-By: Mohammad Shbool <alshboolmoh@gmail.com>
@maskeddeveloper
Copy link
Contributor Author

@mohshbool @3imed-jaberi , i think it's good

3imed-jaberi
3imed-jaberi requested changes Jul 24, 2019
View reviewed changes
Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

يجب عليك تغييرها !! ظننت انك قمت بتغييرها لذلك صادقت على مسهمتك ..

content/docs/hello-world.md Outdated
@@ -11,7 +11,7 @@ next: introducing-jsx.html

```js
ReactDOM.render(
<h1>Hello, world!</h1>,
<h1>مرحبا بالعالم!</h1>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maskeddeveloper ,
لماذا لم تغيرها !

@maskeddeveloper
Copy link
Contributor Author

@3imed-jaberi Could you please check again i don't know why it didn't change
i added another commit for that

@mohshbool mohshbool added approved and removed changes-requested update needed This PR needs update since last commit labels Jul 26, 2019
@mohshbool
Copy link
Member

🎉

3imed-jaberi
3imed-jaberi approved these changes Jul 26, 2019
View reviewed changes
Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good bro 🚀 ..

@3imed-jaberi 3imed-jaberi changed the title [DONE] Hello World [DONE] hello-world.md .. Jul 26, 2019
@3imed-jaberi 3imed-jaberi merged commit 1784b0b into reactjs:master Jul 26, 2019
@tesseralis tesseralis mentioned this pull request Jul 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aissaoui-Ahmed Aissaoui-Ahmed Aissaoui-Ahmed left review comments

@mohshbool mohshbool mohshbool approved these changes

@3imed-jaberi 3imed-jaberi 3imed-jaberi approved these changes

Assignees

@mohshbool mohshbool

@3imed-jaberi 3imed-jaberi

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@maskeddeveloper @3imed-jaberi @mohshbool @Aissaoui-Ahmed @mhamime