Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Done] Translation of tutorial.md .. #135

Merged
merged 20 commits into from Jul 22, 2019

Conversation

3imed-jaberi
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Jul 11, 2019

Deploy preview for ar-reactjs ready!

Built with commit a715e34

https://deploy-preview-135--ar-reactjs.netlify.com

@mohshbool
Copy link
Member

wow this is way longer than I had expected 😅
it'll take me a couple of days ..

content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Show resolved Hide resolved
content/tutorial/tutorial.md Show resolved Hide resolved
content/tutorial/tutorial.md Show resolved Hide resolved
content/tutorial/tutorial.md Show resolved Hide resolved
Copy link
Member

@mohshbool mohshbool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job @3imed-jaberi impressive work 👏
I had a good time reviewing your translation.
I have read some of the suggestions that @Aissaoui-Ahmed made and they made sense so I skipped the part he reviewed.
Also, you should address the reader by as a single reader (he, she) rather than multiples (we, us), example: You changed ... becomes ... قُمت بتغيير rather than قُمنا بتغيير .... Perhaps @Fcmam5 can elaborate on this more. I only made this suggestion once since it'd be tedious to do so multiple times.
Here are some suggestions that I think might better the translation:

content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
@3imed-jaberi
Copy link
Member Author

great job @3imed-jaberi impressive work 👏
I had a good time reviewing your translation.
I have read some of the suggestions that @Aissaoui-Ahmed made and they made sense so I skipped the part he reviewed.
Also, you should address the reader by as a single reader (he, she) rather than multiples (we, us), example: You changed ... becomes ... قُمت بتغيير rather than قُمنا بتغيير .... Perhaps @Fcmam5 can elaborate on this more. I only made this suggestion once since it'd be tedious to do so multiple times.
Here are some suggestions that I think might better the translation:

Thank you bro, but you know that we have a methodology of work that if we change it, we have to discuss this on the Slack.

3imed-jaberi and others added 6 commits July 15, 2019 17:26
Co-Authored-By: Mohammad Shbool <alshboolmoh@gmail.com>
Co-Authored-By: Mohammad Shbool <alshboolmoh@gmail.com>
Co-Authored-By: Mohammad Shbool <alshboolmoh@gmail.com>
Co-Authored-By: Mohammad Shbool <alshboolmoh@gmail.com>
Co-Authored-By: Mohammad Shbool <alshboolmoh@gmail.com>
@3imed-jaberi
Copy link
Member Author

لا يمكن التحول من الدليل التطبيقي إلى الدورة التعلمية خاصة و ان النافبار به ترجمة مصادق عليها ..

image

@mohshbool
Copy link
Member

Thank you bro, but you know that we have a methodology of work that if we change it, we have to discuss this on the Slack.

I actually was gonna do what you are doing but then @Fcmam5 suggested otherwise, afaik.

@3imed-jaberi 3imed-jaberi requested a review from Fcmam5 July 18, 2019 00:06
@Fcmam5
Copy link
Collaborator

Fcmam5 commented Jul 20, 2019

Also, you should address the reader by as a single reader (he, she) rather than multiples (we, us), example: You changed ... becomes ... قُمت بتغيير rather than قُمنا بتغيير ....

I agree I think that it's the way to go. React documentation is kind of "friendly" and it addresses the single reader (he, she).

Copy link
Collaborator

@Fcmam5 Fcmam5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Imad for doing this great job by translating this important part of the documentation.
I have some suggestions that we should look into :)

content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
3imed-jaberi and others added 7 commits July 20, 2019 13:03
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Co-Authored-By: Mohammad Shbool <alshboolmoh@gmail.com>
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Copy link
Member

@mohshbool mohshbool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Collaborator

@Fcmam5 Fcmam5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ﻻزالت هناك تحسينات صغيرة للقيام بها، وأما عن تعريب الأمثلة من عدمه... الأمر يعود لك فأنت المسؤول عن هذا القسم، يمكن أن نعود له لاحقا لتعريب صور النتائج والأمثلة.

بالتوفيق يا صديقي 💪

content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Fcmam5 Fcmam5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

تحيا ناس تونس، ناس العلم والفصاحة 🇹🇳 تحيّة إلى القيروان وجامع الزيتونة وباقي منابر العلم والعلماء، شكرا لك عماد على مساهماتك

@Fcmam5 Fcmam5 added approved and removed in-review labels Jul 22, 2019
@3imed-jaberi 3imed-jaberi self-assigned this Jul 22, 2019
@3imed-jaberi
Copy link
Member Author

تحيا ناس تونس، ناس العلم والفصاحة 🇹🇳 تحيّة إلى القيروان وجامع الزيتونة وباقي منابر العلم والعلماء، شكرا لك عماد على مساهماتك

شكرا لك اخي الغالي على كلماتك الجميلة لطالما كنا شعب و احد و دم واحد .. تحية احترام و اجلال لارض الرجال ارض المليون شهيد 🇩🇿

Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@3imed-jaberi 3imed-jaberi merged commit 9048e9e into reactjs:master Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants