New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Done] Translation of tutorial.md .. #135
Conversation
Deploy preview for ar-reactjs ready! Built with commit a715e34 |
wow this is way longer than I had expected 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job @3imed-jaberi impressive work 👏
I had a good time reviewing your translation.
I have read some of the suggestions that @Aissaoui-Ahmed made and they made sense so I skipped the part he reviewed.
Also, you should address the reader by as a single reader (he, she) rather than multiples (we, us), example: You changed ...
becomes ... قُمت بتغيير
rather than قُمنا بتغيير ...
. Perhaps @Fcmam5 can elaborate on this more. I only made this suggestion once since it'd be tedious to do so multiple times.
Here are some suggestions that I think might better the translation:
Thank you bro, but you know that we have a methodology of work that if we change it, we have to discuss this on the Slack. |
Co-Authored-By: Mohammad Shbool <alshboolmoh@gmail.com>
Co-Authored-By: Mohammad Shbool <alshboolmoh@gmail.com>
Co-Authored-By: Mohammad Shbool <alshboolmoh@gmail.com>
Co-Authored-By: Mohammad Shbool <alshboolmoh@gmail.com>
Co-Authored-By: Mohammad Shbool <alshboolmoh@gmail.com>
I actually was gonna do what you are doing but then @Fcmam5 suggested otherwise, afaik. |
I agree I think that it's the way to go. React documentation is kind of "friendly" and it addresses the single reader (he, she). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Imad for doing this great job by translating this important part of the documentation.
I have some suggestions that we should look into :)
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Co-Authored-By: Mohammad Shbool <alshboolmoh@gmail.com>
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ﻻزالت هناك تحسينات صغيرة للقيام بها، وأما عن تعريب الأمثلة من عدمه... الأمر يعود لك فأنت المسؤول عن هذا القسم، يمكن أن نعود له لاحقا لتعريب صور النتائج والأمثلة.
بالتوفيق يا صديقي 💪
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
تحيا ناس تونس، ناس العلم والفصاحة 🇹🇳 تحيّة إلى القيروان وجامع الزيتونة وباقي منابر العلم والعلماء، شكرا لك عماد على مساهماتك
شكرا لك اخي الغالي على كلماتك الجميلة لطالما كنا شعب و احد و دم واحد .. تحية احترام و اجلال لارض الرجال ارض المليون شهيد 🇩🇿 |
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
No description provided.