Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Done] Translation of faq-functions.md .. #139

Merged
merged 6 commits into from Jul 21, 2019
Merged

[Done] Translation of faq-functions.md .. #139

merged 6 commits into from Jul 21, 2019

Conversation

3imed-jaberi
Copy link
Member

No description provided.

@tesseralis tesseralis mentioned this pull request Jul 19, 2019
Closed
@netlify
Copy link

netlify bot commented Jul 19, 2019 •
edited

Deploy preview for ar-reactjs ready!

Built with commit 01b040c

https://deploy-preview-139--ar-reactjs.netlify.com

Fcmam5
Fcmam5 requested changes Jul 20, 2019
View reviewed changes
Copy link
Collaborator

@Fcmam5 Fcmam5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You own it bro 🇹🇳,
I just got some remarks about some micro-corrections to do and I also referred to an untranslated code example.
Also you should remove the old text in line 147 after you translated Example: Passing params using arrow functions

content/docs/faq-functions.md Outdated Show resolved Hide resolved
content/docs/faq-functions.md Show resolved Hide resolved
content/docs/faq-functions.md Outdated Show resolved Hide resolved
content/docs/faq-functions.md Show resolved Hide resolved
content/docs/faq-functions.md Show resolved Hide resolved
content/docs/faq-functions.md Outdated Show resolved Hide resolved
3imed-jaberi and others added 5 commits July 20, 2019 13:58
@3imed-jaberi @Fcmam5
better expression - ligne 17
4ea62a7 
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@3imed-jaberi @Fcmam5
fix for low level ar - ligne 133
71ad9ac 
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@3imed-jaberi
Compensating forgotten line - L181
64eb8bb
@3imed-jaberi
translate code example - line 313
3585488
@3imed-jaberi @Fcmam5
add english term for more clarify ...... - line 354
01b040c 
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Fcmam5
Fcmam5 approved these changes Jul 21, 2019
View reviewed changes
content/docs/faq-functions.md Show resolved Hide resolved
@Fcmam5 Fcmam5 added approved and removed in-review labels Jul 21, 2019
@Fcmam5 Fcmam5 merged commit 9c623b3 into reactjs:master Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fcmam5 Fcmam5 Fcmam5 approved these changes

Assignees

@Fcmam5 Fcmam5

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@3imed-jaberi @Fcmam5