Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DONE] Update content/community/nav.yml #144

Merged
merged 1 commit into from Jul 31, 2019
Merged

[DONE] Update content/community/nav.yml #144

merged 1 commit into from Jul 31, 2019

Conversation

Aissaoui-Ahmed
Copy link
Member

@Aissaoui-Ahmed Aissaoui-Ahmed commented Jul 22, 2019 •
edited

hi everyone !

translate file content/community/nav.yml

@Aissaoui-Ahmed Aissaoui-Ahmed mentioned this pull request Jul 22, 2019
Closed
20 tasks
@Aissaoui-Ahmed Aissaoui-Ahmed changed the title [DONE]Update nav.yml [DONE] Update content/community/nav.yml Jul 22, 2019
Fcmam5
Fcmam5 requested changes Jul 22, 2019
View reviewed changes
Copy link
Collaborator

@Fcmam5 Fcmam5 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ahmed, thank you very much and congrats for this first contribution 😄 !
Please review the translations, some of my comments only suggest adding "ال" .
Please, feel free to discuss any suggestion you don't feel convinced of it :)

content/community/nav.yml Outdated Show resolved Hide resolved
content/community/nav.yml Outdated Show resolved Hide resolved
content/community/nav.yml Outdated Show resolved Hide resolved
content/community/nav.yml Outdated Show resolved Hide resolved
content/community/nav.yml Outdated Show resolved Hide resolved
content/community/nav.yml Outdated Show resolved Hide resolved
content/community/nav.yml Show resolved Hide resolved
content/community/nav.yml Outdated Show resolved Hide resolved
content/community/nav.yml Show resolved Hide resolved
content/community/nav.yml Outdated Show resolved Hide resolved
@mohshbool mohshbool added update needed This PR needs update since last commit in-review labels Jul 22, 2019
@netlify
Copy link

netlify bot commented Jul 22, 2019 •
edited

Deploy preview for ar-reactjs ready!

Built with commit a9831a0

https://deploy-preview-144--ar-reactjs.netlify.com

@mohshbool mohshbool removed the update needed This PR needs update since last commit label Jul 22, 2019
3imed-jaberi
3imed-jaberi requested changes Jul 27, 2019
View reviewed changes
Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution ❤️ ..

I have suggested some modifications ... you can check them 💯 ..

content/community/nav.yml Outdated Show resolved Hide resolved
content/community/nav.yml Outdated Show resolved Hide resolved
@3imed-jaberi 3imed-jaberi added update needed This PR needs update since last commit work-in-progress and removed in-review labels Jul 29, 2019
Fcmam5
Fcmam5 requested changes Jul 29, 2019
View reviewed changes
content/community/nav.yml Outdated Show resolved Hide resolved
content/community/nav.yml Outdated Show resolved Hide resolved
content/community/nav.yml Outdated Show resolved Hide resolved
Fcmam5
Fcmam5 requested changes Jul 30, 2019
View reviewed changes
content/community/nav.yml Outdated Show resolved Hide resolved
content/community/nav.yml Outdated Show resolved Hide resolved
@Aissaoui-Ahmed
Copy link
Member Author

done!

@3imed-jaberi 3imed-jaberi removed the request for review from mohshbool July 30, 2019 23:32
Fcmam5
Fcmam5 approved these changes Jul 31, 2019
View reviewed changes
Copy link
Collaborator

@Fcmam5 Fcmam5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Ahmed! We are good to go 🚀

@3imed-jaberi 3imed-jaberi added approved and removed in-review update needed This PR needs update since last commit labels Jul 31, 2019
@3imed-jaberi 3imed-jaberi merged commit e39a59b into reactjs:master Jul 31, 2019
@Aissaoui-Ahmed Aissaoui-Ahmed deleted the nan.yml branch August 4, 2019 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fcmam5 Fcmam5 Fcmam5 approved these changes

@3imed-jaberi 3imed-jaberi 3imed-jaberi approved these changes

Assignees

@Fcmam5 Fcmam5

@3imed-jaberi 3imed-jaberi

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Aissaoui-Ahmed @Fcmam5 @3imed-jaberi @mohshbool