Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Done] Translation courses.md - @Moast #148

Merged
merged 6 commits into from Jul 31, 2019
Merged

[Done] Translation courses.md - @Moast #148

merged 6 commits into from Jul 31, 2019

Conversation

3imed-jaberi
Copy link
Member

@3imed-jaberi 3imed-jaberi commented Jul 25, 2019 •
edited

@moast , thank you for your contribution ...

The next time , please create a Pull Request. If you don't know how to do this follow this video ..

@3imed-jaberi 3imed-jaberi mentioned this pull request Jul 25, 2019
Closed
20 tasks
@netlify
Copy link

netlify bot commented Jul 25, 2019 •
edited

Deploy preview for ar-reactjs ready!

Built with commit f6cea75

https://deploy-preview-148--ar-reactjs.netlify.com

Aissaoui-Ahmed
Aissaoui-Ahmed requested changes Jul 25, 2019
View reviewed changes
content/community/courses.md Outdated Show resolved Hide resolved
content/community/courses.md Outdated Show resolved Hide resolved
content/community/courses.md Outdated Show resolved Hide resolved
content/community/courses.md Outdated Show resolved Hide resolved
content/community/courses.md Outdated Show resolved Hide resolved
@moast
Copy link

moast commented Jul 25, 2019

Changed were added

3imed-jaberi
3imed-jaberi commented Jul 29, 2019
View reviewed changes
Copy link
Member Author

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moast
يجب عليك القيام بهذه التغيرات ... لكي يتمكن
netlify
من رفع تغيرات ..

content/community/courses.md Show resolved Hide resolved
content/community/courses.md Outdated Show resolved Hide resolved
@3imed-jaberi 3imed-jaberi added changes-requested update needed This PR needs update since last commit work-in-progress and removed in-review labels Jul 29, 2019
@3imed-jaberi 3imed-jaberi added in-review and removed changes-requested update needed This PR needs update since last commit work-in-progress labels Jul 29, 2019
Fcmam5
Fcmam5 requested changes Jul 29, 2019
View reviewed changes
Copy link
Collaborator

@Fcmam5 Fcmam5 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!
Please review the comments I left and also, remove all إطار عمل React and replace it by simply React or مكتبة React. React is a library, not a framework (مكتبة وليست إطار عمل).
Also, there are some missing همزات, I highlighted some of them, so please review your translation :)

content/community/courses.md Outdated Show resolved Hide resolved
content/community/courses.md Outdated Show resolved Hide resolved
content/community/courses.md Outdated Show resolved Hide resolved
content/community/courses.md Outdated Show resolved Hide resolved
content/community/courses.md Outdated Show resolved Hide resolved
content/community/courses.md Outdated Show resolved Hide resolved
content/community/courses.md Outdated Show resolved Hide resolved
@3imed-jaberi 3imed-jaberi self-assigned this Jul 29, 2019
@3imed-jaberi
Copy link
Member Author

Thank you for your contribution!
Please review the comments I left and also, remove all إطار عمل React and replace it by simply React or مكتبة React. React is a library, not a framework (مكتبة وليست إطار عمل).
Also, there are some missing همزات, I highlighted some of them, so please review your translation :)

please @moast , check this ........

@Aissaoui-Ahmed
Copy link
Member

I suggest "أداءة"

@3imed-jaberi 3imed-jaberi requested review from Fcmam5 and removed request for mohshbool July 30, 2019 23:34
@3imed-jaberi
Copy link
Member Author

I suggest "أداءة"

where ?

@Aissaoui-Ahmed
Copy link
Member

framework > أداءة

Fcmam5
Fcmam5 approved these changes Jul 31, 2019
View reviewed changes
Copy link
Collaborator

@Fcmam5 Fcmam5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at this beauty: https://deploy-preview-148--ar-reactjs.netlify.com/community/courses.html 😄
Good job, and thank you @3imed-jaberi

content/community/courses.md Show resolved Hide resolved
@moast
Copy link

moast commented Jul 31, 2019 •
edited

framework > أداءة

It's incorrect. It can be اداة

@3imed-jaberi 3imed-jaberi merged commit 72d4c75 into reactjs:master Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moast moast moast left review comments

@Fcmam5 Fcmam5 Fcmam5 approved these changes

@Aissaoui-Ahmed Aissaoui-Ahmed Aissaoui-Ahmed approved these changes

Assignees

@Fcmam5 Fcmam5

@mohshbool mohshbool

@3imed-jaberi 3imed-jaberi

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@3imed-jaberi @moast @Aissaoui-Ahmed @Fcmam5 @mohshbool