Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DONE] Update tools-jsx.md #157

Merged
merged 1 commit into from
Aug 17, 2019
Merged

[DONE] Update tools-jsx.md #157

merged 1 commit into from
Aug 17, 2019

Conversation

Aissaoui-Ahmed
Copy link
Member

@Aissaoui-Ahmed Aissaoui-Ahmed commented Aug 4, 2019 •
edited
Loading

translate file : content/community/tools-jsx.md
Ref : here

@netlify
Copy link

netlify bot commented Aug 4, 2019 •
edited
Loading

Deploy preview for ar-reactjs ready!

Built with commit d00a262

https://deploy-preview-157--ar-reactjs.netlify.com

@Aissaoui-Ahmed Aissaoui-Ahmed changed the title [WIP] Update tools-jsx.md [DONE] Update tools-jsx.md Aug 4, 2019
Fcmam5
Fcmam5 requested changes Aug 5, 2019
View reviewed changes
Copy link
Collaborator

@Fcmam5 Fcmam5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Ahmed for your contribution.
I left some remarks and some suggestions please take a peek when you're free :)

content/community/tools-jsx.md Outdated Show resolved Hide resolved
content/community/tools-jsx.md Outdated Show resolved Hide resolved
content/community/tools-jsx.md Outdated Show resolved Hide resolved
content/community/tools-jsx.md Outdated Show resolved Hide resolved
content/community/tools-jsx.md Outdated Show resolved Hide resolved
content/community/tools-jsx.md Outdated Show resolved Hide resolved
content/community/tools-jsx.md Outdated Show resolved Hide resolved
content/community/tools-jsx.md Outdated Show resolved Hide resolved
content/community/tools-jsx.md Outdated Show resolved Hide resolved
content/community/tools-jsx.md Show resolved Hide resolved
@iRayan7 iRayan7 mentioned this pull request Aug 6, 2019
Closed
20 tasks
@mohshbool mohshbool removed their assignment Aug 6, 2019
@mohshbool mohshbool added changes-requested update needed This PR needs update since last commit labels Aug 6, 2019
@iRayan7 iRayan7 requested a review from Fcmam5 August 9, 2019 21:06
Fcmam5
Fcmam5 requested changes Aug 10, 2019
View reviewed changes
Copy link
Collaborator

@Fcmam5 Fcmam5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-review the suggestions, some of them are marked as resolved but it doesn't to be. Maybe because of that you're force-pushing your commits and that doesn't trigger netifly build.

content/community/tools-jsx.md Outdated Show resolved Hide resolved
content/community/tools-jsx.md Outdated Show resolved Hide resolved
content/community/tools-jsx.md Outdated Show resolved Hide resolved
content/community/tools-jsx.md Outdated Show resolved Hide resolved
content/community/tools-jsx.md Outdated Show resolved Hide resolved
content/community/tools-jsx.md Outdated Show resolved Hide resolved
content/community/tools-jsx.md Show resolved Hide resolved
3imed-jaberi
3imed-jaberi requested changes Aug 10, 2019
View reviewed changes
Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

شكرا لك اخ @Aissaoui-Ahmed على مجهوداتك القيمة ❤️ ..

هناك بعض الاقترحات ارجو منك مراجعتها و شكرا لك 💯 ..

content/community/tools-jsx.md Outdated Show resolved Hide resolved
content/community/tools-jsx.md Outdated Show resolved Hide resolved
content/community/tools-jsx.md Outdated Show resolved Hide resolved
content/community/tools-jsx.md Outdated Show resolved Hide resolved
content/community/tools-jsx.md Outdated Show resolved Hide resolved
content/community/tools-jsx.md Outdated Show resolved Hide resolved
content/community/tools-jsx.md Outdated Show resolved Hide resolved
3imed-jaberi
3imed-jaberi requested changes Aug 10, 2019
View reviewed changes
content/community/tools-jsx.md Outdated Show resolved Hide resolved
content/community/tools-jsx.md Outdated Show resolved Hide resolved
@Aissaoui-Ahmed
Copy link
Member Author

/cc @Fcmam5 @3imed-jaberi

@3imed-jaberi
Copy link
Member

please @Fcmam5 , check this then merge it or approve and let me merge it ...

Fcmam5
Fcmam5 requested changes Aug 14, 2019
View reviewed changes
Copy link
Collaborator

@Fcmam5 Fcmam5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know your time is valuable, so just bear with me another minute, please :)

content/community/tools-jsx.md Outdated Show resolved Hide resolved
content/community/tools-jsx.md Outdated Show resolved Hide resolved
@3imed-jaberi 3imed-jaberi merged commit af90bb1 into reactjs:master Aug 17, 2019
@Aissaoui-Ahmed Aissaoui-Ahmed deleted the tools-jsx branch August 17, 2019 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fcmam5 Fcmam5 Fcmam5 approved these changes

@3imed-jaberi 3imed-jaberi 3imed-jaberi approved these changes

Assignees

@Fcmam5 Fcmam5

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Aissaoui-Ahmed @3imed-jaberi @Fcmam5 @mohshbool