Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONE] Translation of tools-routing.md .. #159

Merged
merged 7 commits into from Aug 14, 2019

Conversation

3imed-jaberi
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Aug 9, 2019

Deploy preview for ar-reactjs ready!

Built with commit 785eebb

https://deploy-preview-159--ar-reactjs.netlify.com

content/community/tools-routing.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Fcmam5 Fcmam5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my respect bro for your work 😎 !
I tried to help with some suggestions to commit by replacing route translation.

content/community/nav.yml Show resolved Hide resolved
content/community/tools-routing.md Outdated Show resolved Hide resolved
content/community/tools-routing.md Outdated Show resolved Hide resolved
content/community/tools-routing.md Outdated Show resolved Hide resolved
content/community/tools-routing.md Show resolved Hide resolved
3imed-jaberi and others added 3 commits August 11, 2019 18:35
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@3imed-jaberi 3imed-jaberi requested review from Fcmam5 and iRayan7 and removed request for Fcmam5, splimter, iRayan7 and mohshbool August 11, 2019 17:39
Copy link
Collaborator

@Fcmam5 Fcmam5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go Imed! I approve your PR, I just noticed a small typo if you can fix it that would be great

content/community/tools-routing.md Outdated Show resolved Hide resolved
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@iRayan7 iRayan7 mentioned this pull request Aug 12, 2019
20 tasks
Copy link
Member

@iRayan7 iRayan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@iRayan7 iRayan7 merged commit a1c0597 into reactjs:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants