Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish Translating Testing Environments #202

Merged
merged 5 commits into from Nov 30, 2019

Conversation

mohamedsgap
Copy link
Contributor

No description provided.

@mohamedsgap
Copy link
Contributor Author

@3imed-jaberi @asantarissy Hey guys, I need your reviews for this pull request, I've just finished translating Testing Environemnts

@netlify
Copy link

netlify bot commented Nov 27, 2019

Deploy preview for ar-reactjs ready!

Built with commit 5cdf49b

https://deploy-preview-202--ar-reactjs.netlify.com

Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job @mohamedsgap 💪,
I have some suggestions to check then 🚀 ..

content/docs/testing-environments.md Outdated Show resolved Hide resolved
content/docs/testing-environments.md Outdated Show resolved Hide resolved
content/docs/testing-environments.md Outdated Show resolved Hide resolved
content/docs/testing-environments.md Outdated Show resolved Hide resolved
content/docs/testing-environments.md Outdated Show resolved Hide resolved
content/docs/testing-environments.md Outdated Show resolved Hide resolved
content/docs/testing-environments.md Outdated Show resolved Hide resolved
content/docs/testing-environments.md Outdated Show resolved Hide resolved
content/docs/testing-environments.md Outdated Show resolved Hide resolved
content/docs/testing-environments.md Outdated Show resolved Hide resolved
@3imed-jaberi 3imed-jaberi added changes-requested update needed This PR needs update since last commit and removed in-review labels Nov 28, 2019
@mohamedsgap
Copy link
Contributor Author

@3imed-jaberi @asantarissy @Aissaoui-Ahmed improved the translation after the requested changes! please, check it out :)

@3imed-jaberi 3imed-jaberi added in-review and removed changes-requested update needed This PR needs update since last commit labels Nov 28, 2019
Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please @mohamedsgap, check all suggestion ...

@3imed-jaberi 3imed-jaberi added changes-requested update needed This PR needs update since last commit and removed in-review labels Nov 28, 2019
content/docs/testing-environments.md Outdated Show resolved Hide resolved
content/docs/testing-environments.md Outdated Show resolved Hide resolved
content/docs/testing-environments.md Outdated Show resolved Hide resolved
@mohamedsgap
Copy link
Contributor Author

@Aissaoui-Ahmed @3imed-jaberi I've modified the translation guys! check it out ;)

Copy link
Member

@Aissaoui-Ahmed Aissaoui-Ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove before
، to ،

content/docs/testing-environments.md Outdated Show resolved Hide resolved
content/docs/testing-environments.md Outdated Show resolved Hide resolved
content/docs/testing-environments.md Outdated Show resolved Hide resolved
content/docs/testing-environments.md Outdated Show resolved Hide resolved
content/docs/testing-environments.md Outdated Show resolved Hide resolved
content/docs/testing-environments.md Outdated Show resolved Hide resolved
content/docs/testing-environments.md Outdated Show resolved Hide resolved
@mohamedsgap
Copy link
Contributor Author

@Aissaoui-Ahmed @3imed-jaberi I've made the last changed, check it out!!

@3imed-jaberi 3imed-jaberi added in-review and removed changes-requested update needed This PR needs update since last commit labels Nov 30, 2019
@Aissaoui-Ahmed Aissaoui-Ahmed merged commit 3b89a0d into reactjs:master Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants