Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Translate "Implementation Notes" #372

Closed
wants to merge 1 commit into from

Conversation

mriiad
Copy link

@mriiad mriiad commented Jan 23, 2022

馃毀 Work in progress

@mriiad mriiad changed the title Implementation notes translation: initial commit WIP: Translate "Implementation Notes" Jan 23, 2022
@atefBB
Copy link
Contributor

atefBB commented Jan 23, 2022

This PR does not have any file changes on it !
@mriiad Please check your work.

@mriiad
Copy link
Author

mriiad commented Jan 23, 2022

As written in the description, the work is in progress but I created it as @3imed-jaberi asked for and to allow him to assign the suitable task to me.

Here's our last conversation about this #1 (comment)

@atefBB please feel free to add the needed labels (work-in-progress, help wanted, etc.), otherwise I will convert it to draft before getting all the work done but I guess this is not the most practical way.

@atefBB
Copy link
Contributor

atefBB commented Jan 23, 2022

I think @3imed-jaberi means that you send a PR containing your work, not an empty one! Is that true @3imed-jaberi ?!

@mriiad
Copy link
Author

mriiad commented Jan 23, 2022

Creating a PR labelled 'work-in-progress' would allow him to assign the concerned task to me so others won't ask to do it.
It's kind of reserving the task and notifying interested people that it's in progress.

Absolutely, there will be upcoming commits soon.

But, maybe I'm wrong and there's another way of work so I would like to thank you for these notes and I'm waiting for Imad's instructions.

@3imed-jaberi
Copy link
Member

Hello,
As @atefBB says. and I see that you will do that.
I assign you on #1 for "Implementation Notes"

I think @3imed-jaberi means that you send a PR containing your work, not an empty one! Is that true @3imed-jaberi ?!

Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mriiad please don't forget to ping me when you are done here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants