Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONE] translate conditional rendering page #503

Merged
merged 3 commits into from Jul 11, 2023

Conversation

mrlahmar
Copy link
Contributor

@mrlahmar mrlahmar commented Jul 6, 2023

This PR should translate the conditional rendering page to Arabic.

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 75.6 KB (-2 B) 178.75 KB
/500 75.59 KB (-2 B) 178.75 KB
/[[...markdownPath]] 77.05 KB (-2 B) 180.2 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@AhmedBaset AhmedBaset self-requested a review July 6, 2023 21:23
@AhmedBaset AhmedBaset self-assigned this Jul 6, 2023
Copy link
Collaborator

@AhmedBaset AhmedBaset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review my commit to this branch


### Conditionally returning nothing with `null` {/*conditionally-returning-nothing-with-null*/}
### إرجاع لا شيء شَرطيّا باستعمال `null` {/*conditionally-returning-nothing-with-null*/}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ستكون أفضل لو كانت "عدم إرجاع شيء"


In some situations, you won't want to render anything at all. For example, say you don't want to show packed items at all. A component must return something. In this case, you can return `null`:
في بعض الحالات، قد لا ترغب في عرض أي شيء على الإطلاق. على سبيل المثال، قد ترغب في عدم عرض العناصر المحزومة. يجب على المكون أن يرجع قيمة. في هذه الحالة، يمكنك إرجاع القيمة `null`:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ومثلها هذه الجملة "قد ترغب في عدم عرض أي شيء" بدلا من "قد لا ترغب في عرض أي شيء"


In some situations, you won't want to render anything at all. For example, say you don't want to show packed items at all. A component must return something. In this case, you can return `null`:
في بعض الحالات، قد لا ترغب في عرض أي شيء على الإطلاق. على سبيل المثال، قد ترغب في عدم عرض العناصر المحزومة. يجب على المكون أن يرجع قيمة. في هذه الحالة، يمكنك إرجاع القيمة `null`:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ومثلها هذه الجملة "قد ترغب في عدم عرض أي شيء" بدلا من "قد لا ترغب في عرض أي شيء"

Copy link
Collaborator

@AhmedBaset AhmedBaset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please translate the index of this page in src/content/sidebarLearn.json

@mrlahmar
Copy link
Contributor Author

Hey, @A7med3bdulBaset,

Thank you for your feedback and improvements 🙏. I really appreciate your efforts. I have made the requested changes.

@AhmedBaset AhmedBaset merged commit 0248534 into reactjs:main Jul 11, 2023
4 checks passed
@AhmedBaset
Copy link
Collaborator

Thanks for your contribution
You can now choose another page to translate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants