Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DONE] Translation of docs/nav.yml #97

Merged
merged 25 commits into from Aug 9, 2019
Merged

[DONE] Translation of docs/nav.yml #97

merged 25 commits into from Aug 9, 2019

Conversation

3imed-jaberi
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Jun 4, 2019 •
edited

Deploy preview for ar-reactjs ready!

Built with commit a64df33

https://deploy-preview-97--ar-reactjs.netlify.com

Fcmam5
Fcmam5 requested changes Jun 5, 2019
View reviewed changes
Copy link
Collaborator

@Fcmam5 Fcmam5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did an excellent job Imed! I added some suggestions for some translations, some of them need more discussion, however, I tried to add some resources for any of my comments to not make it opinion based.

Thank you for what you're doing for the community 🙏

content/docs/nav.yml Show resolved Hide resolved
content/docs/nav.yml Show resolved Hide resolved
content/docs/nav.yml Outdated Show resolved Hide resolved
content/docs/nav.yml Show resolved Hide resolved
content/docs/nav.yml Outdated Show resolved Hide resolved
@iRayan7
Copy link
Member

iRayan7 commented Jun 5, 2019

Hi @3imed-jaberi, the navigation part will be left untranslated since it should be the same as the titles of the pages it refers to. So let us leave the PR for now and come back later to put the final touches. Thanks 🙏

@3imed-jaberi @Fcmam5
Update content/docs/nav.yml
790ed08 
fix the translate of thinking-in-react reactjs#37

Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@3imed-jaberi 3imed-jaberi changed the title [Done] Translation of docs/nav.yml [Work In Progress] Translation of docs/nav.yml Jun 5, 2019
@3imed-jaberi
Copy link
Member Author

حسنا قبل كل شيء عيد مبارك عليكم و على كل الإخوة 🎉 ..
انت على حق لكن علينا التثبت في مراجعة الصفحات و عناوينها خاصة لتكون معبرة اكثر للمتلقى و مفهومة و ان شاء الله في المستقبل سنعود هنا و ذالك بمعجم اكبر و اكثر وضوحا .. كما يجب علينا تفاعل اكثر في slack لتفادي مثل هذه الاخطاء في الترجمة و شكرا لكم جمعينا على مجهوداتكم ❤️ ..
@iRayan7 @Fcmam5

@tesseralis tesseralis mentioned this pull request Jul 3, 2019
Closed
@3imed-jaberi
Copy link
Member Author

@Fcmam5 , لقد قمت بعمل resolve لكي تكون المراجعة واضحة بعد تحديثي الاخير ...

@3imed-jaberi 3imed-jaberi changed the title [Work In Progress] Translation of docs/nav.yml [DONE] Translation of docs/nav.yml Aug 7, 2019
Fcmam5
Fcmam5 approved these changes Aug 9, 2019
View reviewed changes
Copy link
Collaborator

@Fcmam5 Fcmam5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect Imed! Clean and clear translations :)

@3imed-jaberi 3imed-jaberi removed the request for review from mohshbool August 9, 2019 12:15
@3imed-jaberi 3imed-jaberi merged commit 3f4db06 into reactjs:master Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fcmam5 Fcmam5 Fcmam5 approved these changes

Assignees

@Fcmam5 Fcmam5

@3imed-jaberi 3imed-jaberi

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@3imed-jaberi @iRayan7 @Fcmam5 @mohshbool