Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate State and Lifecycles #43

Merged
merged 6 commits into from Apr 8, 2019
Merged

Translate State and Lifecycles #43

merged 6 commits into from Apr 8, 2019

Conversation

saidfagan
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Mar 24, 2019

Deploy preview for az-reactjs ready!

Built with commit b7ec92d

https://deploy-preview-43--az-reactjs.netlify.com

@GasimGasimzada
Copy link
Collaborator

Hello @saidfagan,

Could you please translate the title of the page? It is currently in Azerbaijani. Additionally, we try to localize the contents of the source code to make. Otherwise, I think it is fine. @azizaismayilova Could you please check for grammar in case I missed something?

Thanks!

@azizaismayilova
Copy link
Collaborator

Hi @saidfagan @GasimGasimzada here is the list of corrections:

  • Line 34 - ... etməyi öyrənəcəyik.
  • Line 60 - ... önəmli çatışmazlığı
  • Line 106 - Öncəliklə funksiya...
  • Line 168 - ... əlavə edəcəyik.
  • Line 197 - ... komponentində...
  • Line 205 - ... taymeri yaddaşdan silmək
  • Line 207 - ... ** metodları** ...
  • Line 248 - ... ID-sini
  • Line 250 - rewrite sentence
  • Line 252 - ... siləcəyik.
  • Line 259 - correct the verb
  • Line 311 - Sentences in Azerbaijani can not start with "və"
  • Line 317 - delete "və and merge sentences.
  • Line 356 -First sencense ... ikinci formanı . Second sentence "... arqument kimi isə propların "
  • Line 365 - ... arrow funksiyasını istifadə...
  • Line 378 - ... obyekti hazırki state-ə
  • Line 414 - Sentences in Azerbaijani can not start with "və"
  • Line 430 - Please translate "props" to "proplar"

Copy link
Collaborator

@GasimGasimzada GasimGasimzada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@GasimGasimzada
Copy link
Collaborator

GasimGasimzada commented Mar 30, 2019

@saidfagan any info on these changes? There was a merge conflict and I resolved it; however, some of the lines that @azizaismayilova mentioned might be 1-2 lines off.

@saidfagan
Copy link
Contributor Author

Hi guys. Sorry for the delay, been busy last few days. I will make and push all of these corrections today or tomorrow.

@GasimGasimzada
Copy link
Collaborator

No problem. Thank you for the notice:)

@saidfagan
Copy link
Contributor Author

Made required changes. Please merge.

@azizaismayilova
Copy link
Collaborator

Hi @saidfagan , there are a few mistakes that I found.

In line 207, don't make is bold. İ accidentally made a typing mistake in the comment.
Line 259, change the verb to "yaradacağıq".

@GasimGasimzada GasimGasimzada merged commit 8b1fe9d into reactjs:master Apr 8, 2019
@GasimGasimzada
Copy link
Collaborator

Merged! :)

@saidfagan
Copy link
Contributor Author

Thanks.

@saidfagan
Copy link
Contributor Author

And special thanks to @azizaismayilova for indicating mistakes. I will try to improve my skills in the future and make less mistakes.

@tesseralis tesseralis mentioned this pull request Oct 14, 2019
99 tasks
@GasimGasimzada GasimGasimzada added this to the Core milestone Oct 14, 2019
@GasimGasimzada GasimGasimzada changed the title State and lifecycles Translate State and Lifecycles Oct 14, 2019
@GasimGasimzada GasimGasimzada added the new page Translate a new page label Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new page Translate a new page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants