Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate useContext (part 2) #37

Merged
merged 8 commits into from May 31, 2023

Conversation

asif-jalil
Copy link
Contributor

@asif-jalil asif-jalil commented May 22, 2023

Translate useContext hook's usages.

usages

@nafistiham
Copy link
Collaborator

Thanks a lot Asif vai for making quick translations. I would like to request you to not open more than one PR at a time as mentioned in our guidelines. It will help us keep our PR list simple. So, let's open another PR after the previous one is merged and closed. Larger PRs are difficult to review. SImilarly, too many PRs mean too many back and forths. We are trying to find a sweet spot. I think, we can easily accommodate 60/80 line changes in one PR, meaning 40 additions and 40 deletions. Thanks again for your contribution.

@github-actions
Copy link

github-actions bot commented May 25, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@moshfiqrony
Copy link
Collaborator

@asif-jalil bhai assuming you got what @nafistiham bhai explained.

@asif-jalil
Copy link
Contributor Author

Yeah got it.

Copy link
Collaborator

@nafistiham nafistiham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

বেশ গোছানো ভাষান্তর হয়েছে। অনেক ধন্যবাদ। কিছু টাইপো রিকুয়েস্ট করেছি। আর আমরা নন টেকনিকাল শব্ধগুলো একটু বামে ডানে গিয়ে বাংলা করে ফেলতে পারি। সেগুলো ইংরেজি হরফে বা ইংরেজি উচ্চারণে রাখা জরুরি না। ৬৫ নাম্বার লাইনে অমিল ছিল। আবার নিচে একটা লাইন অতিরিক্ত ইংরেজি আছে। দুইটা ঠিক করলে সম্পূর্ণ মিলে যাবে।

যেহেতু দুটি PR এ দিয়েছেন, আমাদের ইস্যুর পরিচ্ছন্নতার জন্য অনুরোধ থাকবে PR দুইটার নাম সহজ করে useContext part 1, useContext part 2 বা সেরকম কিছু করে দেবেন। আবারও ধন্যবাদ।

src/content/reference/react/useContext.md Show resolved Hide resolved
src/content/reference/react/useContext.md Outdated Show resolved Hide resolved
src/content/reference/react/useContext.md Outdated Show resolved Hide resolved
src/content/reference/react/useContext.md Outdated Show resolved Hide resolved
src/content/reference/react/useContext.md Outdated Show resolved Hide resolved
src/content/reference/react/useContext.md Outdated Show resolved Hide resolved
src/content/reference/react/useContext.md Outdated Show resolved Hide resolved
src/content/reference/react/useContext.md Outdated Show resolved Hide resolved
src/content/reference/react/useContext.md Outdated Show resolved Hide resolved
src/content/reference/react/useContext.md Outdated Show resolved Hide resolved
@asif-jalil asif-jalil changed the title Translate: API Reference > Hook > useCallback usages section Translate useContext (part 2) May 30, 2023
Copy link
Collaborator

@nafistiham nafistiham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Asif bhai! LGTM!

@nafistiham nafistiham added this pull request to the merge queue May 31, 2023
Merged via the queue into reactjs:main with commit b142a3d May 31, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants