Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instalation #14

Merged
merged 11 commits into from Jun 5, 2023
Merged

Instalation #14

merged 11 commits into from Jun 5, 2023

Conversation

OndrejDrapalik
Copy link
Collaborator

Resolve #6

@github-actions
Copy link

github-actions bot commented May 29, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 75.4 KB (🟡 +2 B) 178.55 KB
/500 75.39 KB (🟡 +2 B) 178.54 KB
/[[...markdownPath]] 76.81 KB (🟡 +2 B) 179.96 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link
Collaborator

@pchalupa pchalupa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done sir! I have left some minor comments.

src/content/learn/installation.md Outdated Show resolved Hide resolved
src/content/learn/installation.md Outdated Show resolved Hide resolved
src/content/learn/installation.md Outdated Show resolved Hide resolved
src/content/learn/installation.md Show resolved Hide resolved
src/content/learn/installation.md Outdated Show resolved Hide resolved
src/content/learn/installation.md Outdated Show resolved Hide resolved
src/content/learn/installation.md Outdated Show resolved Hide resolved
src/content/learn/installation.md Outdated Show resolved Hide resolved
OndrejDrapalik and others added 6 commits May 29, 2023 18:41
Co-authored-by: Petr Chalupa <chalupa.petr93@gmail.com>
Co-authored-by: Petr Chalupa <chalupa.petr93@gmail.com>
Co-authored-by: Petr Chalupa <chalupa.petr93@gmail.com>
Co-authored-by: Petr Chalupa <chalupa.petr93@gmail.com>
Co-authored-by: Petr Chalupa <chalupa.petr93@gmail.com>
Co-authored-by: Petr Chalupa <chalupa.petr93@gmail.com>
Copy link
Collaborator

@pchalupa pchalupa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My last comment, I like your activity!

src/content/learn/installation.md Outdated Show resolved Hide resolved
Co-authored-by: Petr Chalupa <chalupa.petr93@gmail.com>
Copy link
Collaborator

@pchalupa pchalupa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@matejpolak matejpolak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @OndrejDrapalik! 👏 Nice review @pchalupa! 💪

@pchalupa pchalupa modified the milestones: Learn React, Instalation Jun 5, 2023
@OndrejDrapalik OndrejDrapalik merged commit 28e735a into main Jun 5, 2023
3 checks passed
@OndrejDrapalik OndrejDrapalik deleted the Installation branch June 5, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation
3 participants