Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate refs-must-have-owner warning #112

Merged
merged 15 commits into from Jan 16, 2020

Conversation

wogsland
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Oct 26, 2019

Deploy preview for de-reactjs ready!

Built with commit af8267d

https://deploy-preview-112--de-reactjs.netlify.com

Copy link
Member

@miku86 miku86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wogsland

Hey Bradley,

thanks for your first contribution.
I've made some suggestions, please have a look at them and try to solve them.
If you need some additional information, please ask.

Guessing you are not a native german speaker,
thanks for having the courage to contribute to the translation,
you did a great job 👍

Greetings
Michael

@miku86 miku86 added the needs review from author First review completed. All changes are processed and a final review is required. label Oct 27, 2019
wogsland and others added 9 commits October 30, 2019 04:16
Co-Authored-By: miku86 <miku86coding@gmail.com>
Co-Authored-By: miku86 <miku86coding@gmail.com>
Co-Authored-By: miku86 <miku86coding@gmail.com>
Co-Authored-By: miku86 <miku86coding@gmail.com>
Co-Authored-By: miku86 <miku86coding@gmail.com>
Co-Authored-By: miku86 <miku86coding@gmail.com>
@wogsland wogsland requested a review from miku86 October 30, 2019 09:24
content/warnings/refs-must-have-owner.md Outdated Show resolved Hide resolved
content/warnings/refs-must-have-owner.md Outdated Show resolved Hide resolved
content/warnings/refs-must-have-owner.md Outdated Show resolved Hide resolved
content/warnings/refs-must-have-owner.md Outdated Show resolved Hide resolved
content/warnings/refs-must-have-owner.md Outdated Show resolved Hide resolved
wogsland and others added 4 commits November 7, 2019 07:22
Co-Authored-By: Phil <phil@capshake.com>
Co-Authored-By: Phil <phil@capshake.com>
Co-Authored-By: Phil <phil@capshake.com>
Co-Authored-By: Phil <phil@capshake.com>
@wogsland wogsland requested a review from ph1p November 7, 2019 13:25
Co-Authored-By: Phil <phil@capshake.com>
@wogsland
Copy link
Contributor Author

wogsland commented Dec 27, 2019

@miku86 @ph1p Is there anything I'm missing here that still needs my review?

@ph1p
Copy link
Member

ph1p commented Jan 16, 2020

I think this is fine :) @wogsland Thank you!

@ph1p ph1p merged commit 8786749 into reactjs:master Jan 16, 2020
@ph1p ph1p removed the needs review from author First review completed. All changes are processed and a final review is required. label Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants