Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated advanced/optimizing-performance #44

Merged
merged 24 commits into from Apr 5, 2019

Conversation

damienxy
Copy link
Contributor

@damienxy damienxy commented Mar 9, 2019

No description provided.

@netlify
Copy link

netlify bot commented Mar 9, 2019

Deploy preview for de-reactjs ready!

Built with commit c118194

https://deploy-preview-44--de-reactjs.netlify.com

Copy link
Member

@ph1p ph1p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First suggestions. Don't know if we should write Production or Produktion .

content/docs/optimizing-performance.md Outdated Show resolved Hide resolved
content/docs/optimizing-performance.md Outdated Show resolved Hide resolved
content/docs/optimizing-performance.md Outdated Show resolved Hide resolved
content/docs/optimizing-performance.md Outdated Show resolved Hide resolved
content/docs/optimizing-performance.md Outdated Show resolved Hide resolved
content/docs/optimizing-performance.md Outdated Show resolved Hide resolved
content/docs/optimizing-performance.md Outdated Show resolved Hide resolved
content/docs/optimizing-performance.md Outdated Show resolved Hide resolved
content/docs/optimizing-performance.md Outdated Show resolved Hide resolved
content/docs/optimizing-performance.md Outdated Show resolved Hide resolved
ph1p and others added 10 commits March 14, 2019 20:38
Co-Authored-By: damienxy <33579339+damienxy@users.noreply.github.com>
Co-Authored-By: damienxy <33579339+damienxy@users.noreply.github.com>
Co-Authored-By: damienxy <33579339+damienxy@users.noreply.github.com>
Co-Authored-By: damienxy <33579339+damienxy@users.noreply.github.com>
Co-Authored-By: damienxy <33579339+damienxy@users.noreply.github.com>
Co-Authored-By: damienxy <33579339+damienxy@users.noreply.github.com>
Co-Authored-By: damienxy <33579339+damienxy@users.noreply.github.com>
Co-Authored-By: damienxy <33579339+damienxy@users.noreply.github.com>
Co-Authored-By: damienxy <33579339+damienxy@users.noreply.github.com>
@damienxy
Copy link
Contributor Author

Thanks for the review! I addressed all comments except for Production vs. Produktion. We should first decide with which version we go and then use that coherently all throughout the text. I initially left Production in English because Produktion sounds pretty strange to me. But happy to hear others' opinions :-)

@ph1p ph1p added needs review from author First review completed. All changes are processed and a final review is required. and removed completed - needs review 🧐 labels Mar 21, 2019
@damienxy
Copy link
Contributor Author

@ph1p and @ChrisB9, I had another look and decided to go with Produktion (see changes in my last commit). Sounds better now I think :-)

content/docs/optimizing-performance.md Outdated Show resolved Hide resolved
content/docs/optimizing-performance.md Outdated Show resolved Hide resolved
content/docs/optimizing-performance.md Outdated Show resolved Hide resolved
content/docs/optimizing-performance.md Outdated Show resolved Hide resolved
content/docs/optimizing-performance.md Outdated Show resolved Hide resolved
content/docs/optimizing-performance.md Outdated Show resolved Hide resolved
content/docs/optimizing-performance.md Outdated Show resolved Hide resolved
content/docs/optimizing-performance.md Outdated Show resolved Hide resolved
content/docs/optimizing-performance.md Outdated Show resolved Hide resolved
content/docs/optimizing-performance.md Outdated Show resolved Hide resolved
ph1p and others added 10 commits March 25, 2019 23:49
Co-Authored-By: damienxy <33579339+damienxy@users.noreply.github.com>
Co-Authored-By: damienxy <33579339+damienxy@users.noreply.github.com>
Co-Authored-By: damienxy <33579339+damienxy@users.noreply.github.com>
Co-Authored-By: damienxy <33579339+damienxy@users.noreply.github.com>
Co-Authored-By: damienxy <33579339+damienxy@users.noreply.github.com>
Co-Authored-By: damienxy <33579339+damienxy@users.noreply.github.com>
Co-Authored-By: damienxy <33579339+damienxy@users.noreply.github.com>
Co-Authored-By: damienxy <33579339+damienxy@users.noreply.github.com>
Co-Authored-By: damienxy <33579339+damienxy@users.noreply.github.com>
Co-Authored-By: damienxy <33579339+damienxy@users.noreply.github.com>
@ph1p ph1p removed the needs review from author First review completed. All changes are processed and a final review is required. label Apr 5, 2019
@ph1p ph1p merged commit bbd03a6 into reactjs:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants