Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Meetups Translation #210

Merged
merged 3 commits into from
Mar 22, 2019
Merged

add Meetups Translation #210

merged 3 commits into from
Mar 22, 2019

Conversation

RamirezAlex
Copy link
Contributor

@carburo please review

@RamirezAlex RamirezAlex mentioned this pull request Mar 21, 2019
19 tasks
@netlify
Copy link

netlify bot commented Mar 21, 2019

Deploy preview for es-reactjs ready!

Built with commit c50fb79

https://deploy-preview-210--es-reactjs.netlify.com

Copy link
Member

@carburo carburo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some suggestions with toponyms translations. I am not sure about "Meetups", @alejandronanez prefers to leave it untranslated. As he probably won't be available this week we should leave it untranslated for the moment and have a discussion about it later on Spectrum.

content/community/meetups.md Outdated Show resolved Hide resolved
* [Barcelona](https://www.meetup.com/ReactJS-Barcelona/)

## Sweden {#sweden}
## Suecia {#sweden}
* [Goteborg](https://www.meetup.com/ReactJS-Goteborg/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [Goteborg](https://www.meetup.com/ReactJS-Goteborg/)
* [Gotemburgo](https://www.meetup.com/ReactJS-Goteborg/)

content/community/meetups.md Outdated Show resolved Hide resolved
content/community/meetups.md Outdated Show resolved Hide resolved
content/community/meetups.md Outdated Show resolved Hide resolved
content/community/meetups.md Outdated Show resolved Hide resolved
content/community/meetups.md Outdated Show resolved Hide resolved
content/community/meetups.md Outdated Show resolved Hide resolved
@RamirezAlex
Copy link
Contributor Author

Thank you @carburo, I made the suggested changes.

@carburo
Copy link
Member

carburo commented Mar 22, 2019

Thank you!

@carburo carburo merged commit 8f5bc06 into reactjs:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants