client mounting option #15
Conversation
Client mounting functions by injecting javascript at the end of the HTML body which mounts the react component over the entire document
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
super-cache-money
changed the title
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
A couple big questions before we get into a thorough review… How did you test this? How does this work if the target view uses |
|
I've done some light testing with an app I'm building. Hardly stringent, I must concede. Regarding browserify: I really overlooked that! It'd make this more solid. So I presume the view's JS should be run through browserify right after it's been transformed from JSX...I'm on it. |
|
I'm going to close this out and say if you need this much, use something else like https://github.com/zeit/next.js/ |
The client mounting support is usable without requiring modification of your react view.
It works like this:
<body>in the prerendered string markup.Caveat: The view render
optionsare visible in the injected JS. This includesoptions.settingswhich contains some (sensitive?) information.