React.Component translated #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fa-reactjs ready! Built with commit f4b820c |
sorousht
requested changes
Jul 5, 2020
There was a problem hiding this comment.
Dear @hosseinAMD
Such a great work was translating this huge page so precisely! Thanks so much for the time that you have spent on this page.
I just tried to improve it a bit as a second eye.
Bests,
Soroush
87 tasks
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
hosseinAMD
commented
Jul 6, 2020
hosseinAMD
commented
Jul 6, 2020
hosseinAMD
commented
Jul 6, 2020
sorousht
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK I'm sorry @sorousht for some conflict.
because I've made a mistake and forgot to change branch when I'm creating my pull request and I've requested to merge my
masterbranch!So this is the first one with correct branch.