Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog post translation (You probably don't need derived state) #101

Merged
merged 6 commits into from Mar 29, 2019

Conversation

JeremiePat
Copy link
Collaborator

No description provided.

@netlify
Copy link

netlify bot commented Mar 14, 2019

Deploy preview for fr-reactjs ready!

Built with commit f2a3dcc

https://deploy-preview-101--fr-reactjs.netlify.com

@JeremiePat JeremiePat marked this pull request as ready for review March 15, 2019 17:27
@JeremiePat JeremiePat added the Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR label Mar 15, 2019
@JeremiePat JeremiePat requested a review from tdd March 15, 2019 17:27
@JeremiePat JeremiePat changed the title Translate: You probably don't need derived state Blog post translation (You probably don't need derived state) Mar 18, 2019
@tdd tdd self-assigned this Mar 28, 2019
@tdd tdd added Reviewing Un mainteneur qualifié est en train de composer la revue de code and removed Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR labels Mar 28, 2019
Copy link
Collaborator

@tdd tdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salut @JeremiePat !

Eh ben… Je sais que quand c'est toi qui écris, tu fais beaucoup de fautes, mais là tu t'es surpassé ! 😨 😉

Y'a même des systématiques, genre « cette example » (féminin + a), et beaucoup de « êtres » (paie ton s en trop). Keskispass ?!

En gros c'est du cosmétique ortho / grammaire / syntaxe, pour 98%, et 2% de contresens ou affinages, comme d'hab' quoi : le fond est en gros nickel 👍

@tdd tdd added Reviewed and removed Reviewing Un mainteneur qualifié est en train de composer la revue de code labels Mar 28, 2019
Franchement, faut que j’arrête de vouloir écrire en français ! Ça m'agace prodigieusement de voir la nature des fautes que je fait, d'autant que quand je les voie, elles sont évidentes. Bref, merci pour le relecture ;)

Co-Authored-By: JeremiePat <jeremie.patonnier@gmail.com>
@tdd tdd merged commit c5d5031 into reactjs:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants