Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blog post translation (update on async rendering) #103

Merged
merged 6 commits into from Mar 27, 2019
Merged

Blog post translation (update on async rendering) #103

merged 6 commits into from Mar 27, 2019

Conversation

tdd
Copy link
Collaborator

@tdd tdd commented Mar 14, 2019

No description provided.

@tdd tdd self-assigned this Mar 14, 2019
@tesseralis tesseralis mentioned this pull request Mar 14, 2019
Closed
@netlify
Copy link

netlify bot commented Mar 14, 2019 •
edited

Deploy preview for fr-reactjs ready!

Built with commit 806d17d

https://deploy-preview-103--fr-reactjs.netlify.com

@tdd tdd changed the title WIP: blog (update on async rendering) Blog post translation (update on async rendering) Mar 15, 2019
@tdd tdd marked this pull request as ready for review March 15, 2019 09:53
@tdd tdd requested a review from JeremiePat March 15, 2019 09:53
@tdd tdd added the Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR label Mar 15, 2019
@tdd tdd force-pushed the blog/update-on-async-rendering branch from 41d753d to 6816547 Compare March 15, 2019 14:07
@JeremiePat JeremiePat added Reviewing Un mainteneur qualifié est en train de composer la revue de code and removed Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR labels Mar 18, 2019
JeremiePat
JeremiePat requested changes Mar 18, 2019
View reviewed changes
Copy link
Collaborator

@JeremiePat JeremiePat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salut :)

Bon, ben comme d'habitude, des petits détails. Il me semble que tu n'était pas très concentré au début (beaucoup d’anglicismes dans les tournures mais ça s'arrange par la suite)

examples/update-on-async-rendering/react-dom-properties-before-update-after.js Outdated Show resolved Hide resolved
examples/update-on-async-rendering/react-dom-properties-before-update-after.js Show resolved Hide resolved
examples/update-on-async-rendering/react-dom-properties-before-update-before.js Outdated Show resolved Hide resolved
examples/update-on-async-rendering/react-dom-properties-before-update-before.js Show resolved Hide resolved
examples/update-on-async-rendering/updating-external-data-when-props-change-after.js Outdated Show resolved Hide resolved
content/blog/2018-03-27-update-on-async-rendering.md Outdated Show resolved Hide resolved
content/blog/2018-03-27-update-on-async-rendering.md Outdated Show resolved Hide resolved
content/blog/2018-03-27-update-on-async-rendering.md Outdated Show resolved Hide resolved
content/blog/2018-03-27-update-on-async-rendering.md Outdated Show resolved Hide resolved
content/blog/2018-03-27-update-on-async-rendering.md Show resolved Hide resolved
@JeremiePat JeremiePat added Reviewed and removed Reviewing Un mainteneur qualifié est en train de composer la revue de code labels Mar 18, 2019
@tdd tdd force-pushed the blog/update-on-async-rendering branch from 6816547 to 5566e4d Compare March 18, 2019 21:03
@tdd
Copy link
Collaborator Author

tdd commented Mar 18, 2019

Damned j'aurais pas dû force-pusher, GitHub ne marque pas tes retours comme résolus… Attends, je refais ça…

@tdd tdd force-pushed the blog/update-on-async-rendering branch from 5566e4d to 806d17d Compare March 18, 2019 21:06
@tdd tdd merged commit 20ae92b into master Mar 27, 2019
@tdd tdd deleted the blog/update-on-async-rendering branch March 27, 2019 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeremiePat JeremiePat JeremiePat requested changes

Assignees

@tdd tdd

Labels
Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tdd @JeremiePat