Traduction de la référence API React.Component #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdd
added
the
Pending Review
|
@JeremiePat juste pour être sûr, tu as vu que j'ai sollicité ta review ici ? 😘 |
|
Oui, oui, c'est en cours ;) |
JeremiePat
requested changes
Feb 13, 2019
JeremiePat
added
Reviewed
and removed
Pending Review
|
Hello @JeremiePat ! Merci pour la revue mec. J'ai tout mis à jour. Il reste 3-4 points où on n'est pas 100% d'accord, j'ai répondu et laissé les convos non-résolues, tu peux jeter un œil ? Et c'est moi où tu as lâché l'affaire, hors les titres, vers 70% du contenu ? 😛 |
tdd
force-pushed
the
reference-react-component
branch
from
205b962
to
f0b96d9
Compare
|
@JeremiePat si tu as un moment aujourd'hui pour revenir sur les 3-4 points que j'ai contestés… 😉 |
|
Désolé, j’étais totalement indisponible hier. Les deux points sur lesquels je chipote, je ne me battrait pas indéfiniment dessus. Si tu continue d'objecter, tu peux souverainement décider que bon ça va :P |
|
OK donc je décide souverainement 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.